Skip to content

fix: retain main in mixed PR target lists - #1219

Merged
panva merged 2 commits into
nodejs:mainfrom
panva:reliability-retargeted-main
Oct 15, 2026
Merged

panva merged 2 commits into
nodejs:mainfrom
panva:reliability-retargeted-main

Conversation

@panva

@panva panva commented Oct 15, 2026

Copy link
Copy Markdown
Member

Hide the target annotation only when main is the sole recorded target. Keep it visible alongside other targets after a PR is retargeted.

Hide the target annotation only when main is the sole recorded target.
Keep it visible alongside other targets after a PR is retargeted.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.50%. Comparing base (7b0bc8e) to head (066054e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1219   +/-   ##
=======================================
  Coverage   64.49%   64.50%           
=======================================
  Files          65       65           
  Lines       12298    12300    +2     
=======================================
+ Hits         7932     7934    +2     
  Misses       4366     4366           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95

aduh95 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Duplicate of #1218?

@panva

panva commented Oct 15, 2026 •

Copy link
Copy Markdown
Member Author

Duplicate of #1218?

Yes, same fix. This one here also updates the test expectations and covers repeated runs targeting only main. I left out (target: none) because the aggregator always records a branch or unknown, so an empty list isn't reachable.

Comment thread lib/ci/failure_aggregator.js Outdated
Comment thread lib/ci/failure_aggregator.js Outdated
@panva
panva merged commit c8e69a7 into nodejs:main Oct 15, 2026
11 checks passed
@aduh95

aduh95 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

c8e69a7 has not a great commit message

Re-landed in bdc212b

@panva

panva commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

yeah i tried to cancel the UI as soon as i hit rebase instead of squash. i'm not able to force push to fix this...

@panva
panva deleted the reliability-retargeted-main branch October 15, 2026 12:52
@aduh95

This comment was marked as outdated.

@aduh95

This comment was marked as resolved.

aduh95 pushed a commit that referenced this pull request Oct 15, 2026
Hide the target annotation only when main is the sole recorded target.
Keep it visible alongside other targets after a PR is retargeted.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants