Repository navigation
feat: show PR target branches and shorten links in CI reports - #1217
Merged
Merged
Conversation
Read PR_BASE_BRANCH from nested Jenkins commit builds so reliability reports show the target recorded for each run. Retain distinct targets across repeated runs of a PR and mark missing metadata as unknown. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Member
Author
|
Failures in node-test-pull-request/78248 to node-test-pull-request/78399 that failed 2 or more PRs
Jenkins Failure
Example
Example
ExampleGit Failure
ExampleBuild Failure
Example
Example
Example
Example
Example
Example
Example
Exampleundefined
ExampleCCTest FailureJSTest FailureExample
Example
Example
Example
Example |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
+ Coverage 63.12% 64.49% +1.37%
==========================================
Files 65 65
Lines 12257 12298 +41
==========================================
+ Hits 7737 7932 +195
+ Misses 4520 4366 -154 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Do you think we could try reducing the noise by not showing it for |
Member
Author
We could but I don't see the point in introducing "default when missing" for a report. |
aduh95
reviewed
Oct 15, 2026
| .map(({ source, upstream }) => ({ | ||
| source, | ||
| upstream, | ||
| targetBranches: [...branchesBySource.get(source)], |
Contributor
There was a problem hiding this comment.
In what case would we have several target branches for a single PR? 🤔
Member
Author
There was a problem hiding this comment.
Technically PRs can be re-target.
Contributor
Not sure I follow, my suggestion was to show |
Member
Author
I got it, just don't see / agree with the point of it. |
Contributor
|
You're saying you'd rather have all those |
Member
Author
Yes, I would. |
Member
Author
|
Updated example output: Failures in node-test-pull-request/78248 to node-test-pull-request/78399 that failed 2 or more PRs
Jenkins Failure
Example
Example
ExampleGit Failure
ExampleBuild Failure
Example
Example
Example
Example
Example
Example
Example
Exampleundefined
ExampleCCTest FailureJSTest Failure
Example
Example
Example
Example
Example |
aduh95
approved these changes
Oct 15, 2026
aduh95
left a comment
aduh95
left a comment
Contributor
There was a problem hiding this comment.
I find the version with implicit target: main more readable, but at the end of the day you're reading those more often than I do, so I trust your judgement and both versions LGTM
panva
changed the title
aduh95
reviewed
Oct 15, 2026
| : branch); | ||
| return ` (target: ${branches.join(', ')})`; | ||
| const branches = pr.targetBranches | ||
| .filter(branch => branch !== 'main') |
Contributor
There was a problem hiding this comment.
Wait that's not OK, we shouldn't do it like that, if the base changed we still want to list main alongside the other branch(es)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read PR_BASE_BRANCH from nested Jenkins commit builds so reliability reports show the target recorded for each run. Retain distinct targets across repeated runs of a PR and mark missing metadata as unknown.
Assisted-by: Codex
Example output for https://github.com/nodejs/reliability/blob/main/reports/2026-10-15.md below