Skip to content

CFG: Handle parameter cfg explicitly. #22807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aschackmull wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CFG: Handle parameter cfg explicitly. #22807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions shared/controlflow/codeql/controlflow/ControlFlowGraph.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,11 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
not postOrInOrder(n) and
not additionalNode(n, _, _) and
not inConditionalContext(n, _)
or
// A parameter pattern represented by the parameter itself should not be
// considered to have child nodes.
n.(Parameter).getPattern() = n and
not inConditionalContext(n, _)
}

private string catchClauseEmptyBodyTag() { result = "[CatchClauseEmptyBody]" }
Expand Down Expand Up @@ -1507,6 +1512,11 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
n2.isBefore(getParameterPatternOrBodyEntry(c, _, 1))
or
exists(CallableContextOption ctx, Parameter p, int i | p = getRankedParameter(c, ctx, i) |
exists(p.getDefaultValue()) and
p.getPattern() = p and
n1.isBefore(p) and
n2.isAfter(p)
or
exists(MatchingSuccessor t |
n1.isAfterValue(p.getPattern(), t) and
if t.isMatch()
Expand Down
Loading