Repository navigation
CFG: Handle parameter cfg explicitly. - #22807
Draft
aschackmull wants to merge 1 commit into
Draft
aschackmull wants to merge 1 commit into
aschackmull wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup for #22791.
Parameter patterns are in many cases represented by the parameter itself. In these cases the CFG should be just a single node or before+after nodes when there's a match condition preceding a default value. Previously, we relied on the default CFG for this, but this only works when the parameter doesn't have any AST children (as specified by the
getChildpredicate in the CFG input). In order to fix this, it's better to simply specify the CFG explicitly.