Skip to content

chore(deps): update dependency java-jdk to v25 #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 1 commit into from
+1 −1
Closed

chore(deps): update dependency java-jdk to v25 #8021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-integrations-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6
with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Check warning on line 47 in .github/workflows/test-integrations-tasks.yml

View check run for this annotation

@sentry/warden / warden: code-review

JDK bump edits generated workflow, leaves template at 21 

Update `java-version` in `scripts/split_tox_gh_actions/templates/test_group.jinja` and regenerate; this file is auto-generated and the next split run will revert 25 back to 21.

Check warning on line 47 in .github/workflows/test-integrations-tasks.yml

View check run for this annotation

@sentry/warden / warden: code-review

Spark integration tests now run on JDK 25 without a compatibility pin 

This changes the JVM used by Spark integration tests to Temurin 25. The current PySpark 3.5.9 and 4.2.0 tox factors do not match the existing Java 11 override, so their local `SparkContext` startup will use JDK 25. Please validate these combinations before merging or pin the Spark tests to a supported JDK.

Check warning on line 47 in .github/workflows/test-integrations-tasks.yml

View check run for this annotation

@sentry/warden / warden: find-bugs

Spark 3.5.9 tests run with unsupported JDK 25 

The Spark 3.5.9 tox environments inherit JDK 25, which is outside the supported Java versions for that Spark line. This can make SparkContext startup fail in the integration tests. Use a supported JDK for those environments, or limit the JDK 25 upgrade to jobs whose Spark versions support it.

@sentry-warden sentry-warden Bot Oct 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK bump edits generated workflow, leaves template at 21

Update java-version in scripts/split_tox_gh_actions/templates/test_group.jinja and regenerate; this file is auto-generated and the next split run will revert 25 back to 21.

Evidence
  • File header states this YAML is generated by scripts/split_tox_gh_actions/split_tox_gh_actions.py and must not be edited by hand.
  • Source template scripts/split_tox_gh_actions/templates/test_group.jinja still hardcodes java-version: '21' under {% if needs_java %}.
  • needs_java is set when the group includes spark (FRAMEWORKS_NEEDING_JAVA), so regeneration rewrites this workflow from the template.

Identified by Warden · code-review · F77-BY4

@sentry-warden sentry-warden Bot Oct 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spark integration tests now run on JDK 25 without a compatibility pin

This changes the JVM used by Spark integration tests to Temurin 25. The current PySpark 3.5.9 and 4.2.0 tox factors do not match the existing Java 11 override, so their local SparkContext startup will use JDK 25. Please validate these combinations before merging or pin the Spark tests to a supported JDK.

Evidence
  • The workflow installs Temurin 25 before running the Spark tox environments.
  • tox.ini defines Spark factors for PySpark 3.5.9 and 4.2.0; its Java 11 override names only Spark 3.0.3 and 3.5.6.
  • The Spark tests create a local SparkContext, which starts the JVM selected by the environment.

Identified by Warden · code-review · TQ6-CST

@cursor cursor Bot Oct 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 25 unsupported by Spark 3.5

Medium Severity

This JDK is installed for Spark tests, and pyspark 3.5.9 has no JAVA_HOME override. Spark 3.5 supports only Java 8/11/17; Java 25 support arrived in Spark 4.2.0. Those envs will start a real SparkContext on Java 25, which can fail the Tasks job.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.

@cursor cursor Bot Oct 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated workflow diverges from template

Low Severity

This file is generated from test_group.jinja, which still sets java-version to 21. Updating only the generated workflow leaves the source of truth unchanged, so the next split_tox_gh_actions.py or weekly toxgen run will revert the bump.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.

- name: Mark workspace safe for git (3.6/3.7 container)
# needed to make git rev-parse work in the containers
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
Expand Down
Loading