Repository navigation
chore(deps): update dependency java-jdk to v25 - #8021
renovate[bot] wants to merge 1 commit into
Conversation
|
We can't do this, it breaks older spark versions. |
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
There was a problem hiding this comment.
JDK bump edits generated workflow, leaves template at 21
Update java-version in scripts/split_tox_gh_actions/templates/test_group.jinja and regenerate; this file is auto-generated and the next split run will revert 25 back to 21.
Evidence
- File header states this YAML is generated by
scripts/split_tox_gh_actions/split_tox_gh_actions.pyand must not be edited by hand. - Source template
scripts/split_tox_gh_actions/templates/test_group.jinjastill hardcodesjava-version: '21'under{% if needs_java %}. needs_javais set when the group includesspark(FRAMEWORKS_NEEDING_JAVA), so regeneration rewrites this workflow from the template.
Identified by Warden · code-review · F77-BY4
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
There was a problem hiding this comment.
Spark integration tests now run on JDK 25 without a compatibility pin
This changes the JVM used by Spark integration tests to Temurin 25. The current PySpark 3.5.9 and 4.2.0 tox factors do not match the existing Java 11 override, so their local SparkContext startup will use JDK 25. Please validate these combinations before merging or pin the Spark tests to a supported JDK.
Evidence
- The workflow installs Temurin 25 before running the Spark tox environments.
tox.inidefines Spark factors for PySpark 3.5.9 and 4.2.0; its Java 11 override names only Spark 3.0.3 and 3.5.6.- The Spark tests create a local
SparkContext, which starts the JVM selected by the environment.
Identified by Warden · code-review · TQ6-CST
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
There was a problem hiding this comment.
Java 25 unsupported by Spark 3.5
Medium Severity
This JDK is installed for Spark tests, and pyspark 3.5.9 has no JAVA_HOME override. Spark 3.5 supports only Java 8/11/17; Java 25 support arrived in Spark 4.2.0. Those envs will start a real SparkContext on Java 25, which can fail the Tasks job.
Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
There was a problem hiding this comment.
Generated workflow diverges from template
Low Severity
This file is generated from test_group.jinja, which still sets java-version to 21. Updating only the generated workflow leaves the source of truth unchanged, so the next split_tox_gh_actions.py or weekly toxgen run will revert the bump.
Reviewed by Cursor Bugbot for commit a1f5fd5. Configure here.
Coverage Results 📊✅ 133643 passed | ❌ 10 failed | ⏭️ 7276 skipped | Total: 140929 | Pass Rate: 94.83% | Execution Time: 435m 9s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
➖ Removed Tests (1)View removed tests
❌ Failed Tests
|


This PR contains the following updates:
21→25Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.