Skip to content

ref(aws-lambda): Clean up aws-lambda - #7939

Merged
pabloDeputter merged 3 commits into
major/3.0from
pablo/cleanup-lambda
Oct 16, 2026
Merged

pabloDeputter merged 3 commits into
major/3.0from
pablo/cleanup-lambda

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

  • use of f-strings instead ”...”.format().
  • move constants into consts.py.
  • add new attributes to SPANDATA (will be used in the next PR).

@pabloDeputter
pabloDeputter added this pull request to stack #7940 October 9, 2026 11:34
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 56199 passed | ⏭️ 2872 skipped | Total: 59071 | Pass Rate: 95.14% | Execution Time: 159m 40s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -81871
Passed Tests 📉 -77467
Failed Tests —
Skipped Tests 📉 -4404

All tests are passing successfully.

✅ Patch coverage is 100.00% (23 of 23 changed executable lines covered; target 80%).
Project statement coverage is 90.05% (down 0.20 percentage points from base (808e219) to head (26ca6de)).

Changed files with executable lines (2)
File Patch coverage Changed executable lines
sentry_sdk/consts.py 100.00% 20/20 covered
sentry_sdk/integrations/aws_lambda/consts.py 100.00% 3/3 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #7939       +/-##
==========================================
- Coverage    90.25%    90.05%    -0.20%
==========================================
  Files          202       197        -5
  Tracked lines     26660     20973     -5687
  Branches      9926      7206     -2720
==========================================
- Hits         24062     18887     -5175
+ Misses        2598      2086      -512
+ Partials      1510      1234      -276

Generated by Coverage Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 9, 2026 12:57
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 9, 2026 12:57
@pabloDeputter
pabloDeputter removed this pull request from stack #7940 October 15, 2026 18:35
@pabloDeputter
pabloDeputter added this pull request to stack #8043 October 15, 2026 19:20

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we're using ORIGIN in more places in this PR -- I think in that case we can keep it the consts file (and the file itself).

Base automatically changed from pablo/refactor-aws_lambda to major/3.0 October 16, 2026 12:50
@pabloDeputter
pabloDeputter merged commit 009f15f into major/3.0 Oct 16, 2026
149 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/cleanup-lambda branch October 16, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants