Skip to content

ref(aws-lambda): Refactor aws-lambda integration - #7938

Merged
pabloDeputter merged 3 commits into
major/3.0from
pablo/refactor-aws_lambda
Oct 16, 2026
Merged

pabloDeputter merged 3 commits into
major/3.0from
pablo/refactor-aws_lambda

Conversation

@pabloDeputter

@pabloDeputter pabloDeputter commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Description

Move aws-lambda integraton into package; moved some constants that are now used across modules in aws_lambda/consts.py.

Mainly done for ease of future development and diff-checks

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 9, 2026 10:22
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 9, 2026 10:22
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 56198 passed | ❌ 1 failed | ⏭️ 2872 skipped | Total: 59071 | Pass Rate: 95.14% | Execution Time: 154m 3s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -81871
Passed Tests 📉 -77468
Failed Tests 📈 +1
Skipped Tests 📉 -4404

❌ Patch coverage is 39.83% (94 of 236 changed executable lines covered; target 80%).
Project statement coverage is 90.04% (down 0.21 percentage points from base (774ea06) to head (6664056)).

Changed files with executable lines (6)
File Patch coverage Changed executable lines
sentry_sdk/integrations/aws_lambda/_handler.py 20.00% 15/75 covered; missed: 39, 41, 42, 55, 56, 58, 59, 61, 62, 63, 65, 66, 68, 72, 74, 75, 77, 78, 79, 80, 81, 89, 93, 97, 105, 107, 110, 111, 113, 114, 115, 119, 120, 121, 125, 126, 127, 128, 129, 133, 134, 136, 137, 138, 139, 141, 146, 148, 149, 150, 172, 173, 174, 175, 176, 180, 181, 183, 184, 186
sentry_sdk/integrations/aws_lambda/_runtime.py 22.00% 11/50 covered; missed: 23, 25, 26, 28, 29, 31, 32, 33, 37, 41, 42, 43, 47, 68, 70, 72, 76, 77, 78, 79, 82, 101, 102, 103, 104, 106, 109, 110, 112, 115, 117, 121, 122, 123, 124, 125, 126, 127, 138
sentry_sdk/integrations/aws_lambda/_request.py 69.86% 51/73 covered; missed: 21, 27, 29, 30, 31, 33, 34, 35, 37, 70, 78, 79, 80, 84, 85, 93, 94, 95, 99, 100, 103, 122; partial branches: 20, 24, 69, 77, 90, 92, 97, 98, 121
sentry_sdk/integrations/aws_lambda/init.py 36.36% 12/33 covered; missed: 24, 28, 29, 30, 34, 36, 37, 41, 43, 47, 49, 52, 53, 57, 62, 63, 64, 65, 67, 69, 74
sentry_sdk/integrations/aws_lambda/consts.py 100.00% 4/4 covered
sentry_sdk/integrations/chalice.py 100.00% 1/1 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #7938       +/-##
==========================================
- Coverage    90.25%    90.04%    -0.21%
==========================================
  Files          202       197        -5
  Tracked lines     26660     20950     -5710
  Branches      9926      7206     -2720
==========================================
- Hits         24062     18864     -5198
+ Misses        2598      2086      -512
+ Partials      1510      1234      -276

Generated by Coverage Action

@pabloDeputter
pabloDeputter added this pull request to stack #7940 October 9, 2026 11:34
@pabloDeputter
pabloDeputter force-pushed the pablo/refactor-aws_lambda branch from 81e5cb8 to 83361bb Compare October 12, 2026 09:06
@pabloDeputter
pabloDeputter removed this pull request from stack #7940 October 15, 2026 18:35
@pabloDeputter
pabloDeputter changed the base branch from master to major/3.0 October 15, 2026 18:36
@pabloDeputter
pabloDeputter force-pushed the pablo/refactor-aws_lambda branch from 83361bb to e3dabcd Compare October 15, 2026 19:20
@pabloDeputter
pabloDeputter added this pull request to stack #8043 October 15, 2026 19:20

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring!

Splitting stuff into more files can be good, but sometimes it creates unnecessary indirection that then leads to more context switching when trying to understand the flow. Same for splitting stuff into functions. Left some comments about that.

Also: I haven't checked the implementation details at all, since as I understand this is just a restructuring with no logic changes, but let me know if that's not the case.

Comment thread sentry_sdk/integrations/aws_lambda/consts.py
Comment thread sentry_sdk/integrations/aws_lambda/__init__.py Outdated
Comment thread sentry_sdk/integrations/aws_lambda/_runtime.py Outdated

Copy link
Copy Markdown
Member Author

Yes, the first 2 PRs are only refactoring. So no logic change.

@pabloDeputter
pabloDeputter merged commit 808e219 into major/3.0 Oct 16, 2026
150 of 153 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/refactor-aws_lambda branch October 16, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants