Repository navigation
Return false when dotenv contains only valueless declarations - #733
Open
srijan2607 wants to merge 1 commit into
Open
srijan2607 wants to merge 1 commit into
srijan2607 wants to merge 1 commit into
Conversation
Implemented and tested with AI assistance; independently reviewed by a separate AI agent. Pending Srijan's human review; not submitted upstream.
srijan2607
marked this pull request as ready for review
October 15, 2026 15:39
Author
|
All nine CI test jobs are passing. Could this be reviewed when convenient? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_dotenv()returnsTruefor content containing only bare declarations such asEXAMPLE_KEY, although those declarations are ignored and cannot set environment variables.Return
Falsewhen all parsed values areNone, matching the existing empty-configuration result. Empty-string assignments remain valid, and valued assignments skipped byoverride=Falseretain their existing result. Parsing, interpolation and environment contents are unchanged.Add 22 regression cases covering file/stream inputs, both override modes, existing environment values, bare-only declarations, empty assignments and mixed content.
Testing on Python 3.13.13:
git diff --checkpassed.Kept as a draft pending CI verification; local results are not a CI pass. Windows and other Python versions have not been tested locally.