Skip to content

chore: Replace serde_yaml with yaml_serde - #904

Open
xeniape wants to merge 2 commits into
mainfrom
chore/replace-serde-yaml
Open

xeniape wants to merge 2 commits into
mainfrom
chore/replace-serde-yaml

Conversation

@xeniape

@xeniape xeniape commented Oct 14, 2026

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#898

Integrationtests

--- PASS: kuttl (1513.53s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_opa-1.16.2_openshift-false_use-tls-false (101.77s)
        --- PASS: kuttl/harness/logging_opa-1.20.2_openshift-false (126.86s)
        --- PASS: kuttl/harness/workload-kind_opa-latest-1.20.2_openshift-false (48.95s)
        --- PASS: kuttl/harness/logging_opa-1.16.2_openshift-false (72.28s)
        --- PASS: kuttl/harness/config-overrides_opa-latest-1.20.2_openshift-false (58.66s)
        --- PASS: kuttl/harness/aas-user-info_opa-latest-1.20.2_openshift-false (140.12s)
        --- PASS: kuttl/harness/cluster-operation_opa-latest-1.20.2_openshift-false (51.15s)
        --- PASS: kuttl/harness/resources_opa-latest-1.20.2_openshift-false (19.62s)
        --- PASS: kuttl/harness/keycloak-user-info_opa-latest-1.20.2_keycloak-23.0.1_openshift-false (260.40s)
        --- PASS: kuttl/harness/openldap-user-info_opa-latest-1.20.2_openshift-false (132.68s)
        --- PASS: kuttl/harness/smoke_opa-1.20.2_openshift-false_use-tls-false (58.85s)
        --- PASS: kuttl/harness/smoke_opa-1.20.2_openshift-false_use-tls-true (54.49s)
        --- PASS: kuttl/harness/smoke_opa-1.16.2_openshift-false_use-tls-true (60.13s)
        --- PASS: kuttl/harness/data-hub-resource-info_opa-latest-1.20.2_trino-latest-483_kafka-latest-4.2.1_superset-latest-6.1.0_data-hub-1.0.3_data-hub-prerequisites-0.3.0_openshift-false (1314.37s)
PASS

Unittests

test result: ok. 13 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.09s

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 14, 2026
@xeniape
xeniape marked this pull request as ready for review October 14, 2026 15:15
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 14, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants