Repository navigation
ci(dependabot): update every Go module in the repository - #4640
Open
kyleconroy wants to merge 3 commits into
Open
kyleconroy wants to merge 3 commits into
kyleconroy wants to merge 3 commits into
Conversation
The examples module replaces github.com/sqlc-dev/sqlc with ../, so a bump that lands only in the root go.mod leaves it out of step (see #4635 and #4639). Listing both directories lets each grouped update cover both modules in one pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LyueKDc8vSZZALuaDh9RSq
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LyueKDc8vSZZALuaDh9RSq
kyleconroy
changed the title
The module only exists so CI can compile the committed golden code, and that code builds against the latest version of every driver it imports. Raise its go directive to 1.26.0, matching the other modules, since the current releases of several of its dependencies require it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LyueKDc8vSZZALuaDh9RSq
kyleconroy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples module replaces
github.com/sqlc-dev/sqlcwith../, so it has to carry the same versions as the root module. Dependabot only watched the rootgo.mod, which is why #4635 had to be replaced by #4639 with a manualgo mod tidyinexamples/.This switches the
gomodentry fromdirectory: "/"todirectorieslisting all four Go modules://examples/internal/goldeneye— never watched before; it has drifted (still on grpc 1.83.2, for example)/internal/endtoend/testdata— only exists so CI cango buildthe committed golden codeWith the existing production and development groups, Dependabot opens one pull request per group spanning all of them, so a bump lands in every
go.modtogether.The endtoend testdata module's
godirective goes from 1.25.0 to 1.26.0, matching the other three. Current releases of several of its dependencies (google.golang.org/api,genproto,x/tools) require Go 1.26, so without this Dependabot could not update them.Testing
go build ./...ininternal/endtoend/testdatapasses after thegodirective change.go get -u ./... && go mod tidy && go build ./...ininternal/endtoend/testdataalso passes. That moved pgx v4 from a 2020 commit to 4.18.3,lib/pq1.9.0 → 1.12.3,go-sql-driver/mysql1.7.0 → 1.10.1, pgx v5 → 5.11.0, and more, so the golden code builds against current drivers.go test ./internal/endtoend -run TestReplay/basepasses.Updates that fall outside the groups (security updates, for example) may still arrive as one pull request per directory.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LyueKDc8vSZZALuaDh9RSq