Repository navigation
fix(create-rstack): invalidate Nx cache when environment files change - #577
chenjiahan wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
520c352
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c73b8e3.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-fix-nx-template-e-vgbj.rstack-cli.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0e727af7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "{workspaceRoot}/rstack.config.ts", | ||
| "{workspaceRoot}/pnpm-workspace.yaml" | ||
| "{workspaceRoot}/pnpm-workspace.yaml", | ||
| { "fileset": "{workspaceRoot}/.env*", "includeIgnored": true } |
There was a problem hiding this comment.
.env
When a generated workspace uses Nx's supported reverse-form environment filenames at the workspace root, such as .local.env, .build.env, or .build.production.env, Nx loads them into build and test tasks, but this {workspaceRoot}/.env* input does not match them. Because workspace-root files are also outside each app's {projectRoot}/**/*, changing one after a cached run can restore stale output. Nx documents both naming forms in its environment-file loading order, so the shared input should cover the workspace variants that end in .env as well.
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Motivation
Changing environment files in a generated Nx workspace can reuse stale build output because Nx excludes Git-ignored files from its default cache inputs and project inputs do not cover workspace-root environment files.
Changes
Include project and workspace environment files in cache inputs with
includeIgnored: true, covering both.env*and.*.envnaming forms. Explicitly apply the named inputs to build and test tasks, including their dependencies.Validated environment-file additions, changes, and removal, plus cache hits and output restoration in a generated Nx project. Reproduced stale output after changing a workspace
.build.env, then verified the fix with workspace.build.env/.local.envand Git-ignored project.local.env. All 32 scaffold tests pass.Split from #576, which separately fixes dotenv loading precedence. Both PRs target
mainand can be merged independently.