Skip to content

fix(Fabric, iOS): soften the _props subclass assert in RCTViewComponentView.updateProps #59142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
talha7k wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −7
Open

fix(Fabric, iOS): soften the _props subclass assert in RCTViewComponentView.updateProps #59142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,21 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &

#ifndef NS_BLOCK_ASSERTIONS
auto propsRawPtr = _props.get();
RCTAssert(
propsRawPtr &&
([self class] == [RCTViewComponentView class] ||
typeid(*propsRawPtr).hash_code() != typeid(const ViewProps).hash_code()),
@"`RCTViewComponentView` subclasses (and `%@` particularly) must setup `_props`"
" instance variable with a default value in the constructor.",
NSStringFromClass([self class]));
// SOFTENED: third-party component views that reset _props to base ViewProps
// in prepareForRecycle (observed: react-native-maps RNMapsGoogleMapView) can
// receive updateProps with base ViewProps on the deep-link mount path
// (RN 0.88 + new arch). Aborting there takes the whole app down on a
// diagnostic-only invariant, and the static_casts below are valid for base
// ViewProps anyway. Log instead of abort.
if (!(propsRawPtr &&
([self class] == [RCTViewComponentView class] ||
typeid(*propsRawPtr).hash_code() != typeid(const ViewProps).hash_code()))) {
RCTLogError(
@"`RCTViewComponentView` subclass `%@` received updateProps with base "
"ViewProps (_props not set by the subclass constructor or recycled). "
"Continuing with base props.",
NSStringFromClass([self class]));
}
#endif

const auto &oldViewProps = static_cast<const ViewProps &>(*_props);
Expand Down
Loading