Repository navigation
Conversation
Summary: The View-based `UIManager` lifecycle predates `ReactHost` and `ReactSurface` and is no longer used by the supported architecture. Deprecate these methods before their planned removal and point callers to `ReactHost.createSurface(...)` and `ReactSurface.start()` or `stop()`. Changelog: [Android][Deprecated] - Deprecate the legacy View-based surface lifecycle methods in `UIManager`. Reviewed By: christophpurrer Differential Revision: D124990160
Summary: ReactInstanceManager can no longer initialise the legacy bridge, so the bridge+Fabric surface lifecycle JNI entry points are unreachable. Remove those methods while retaining the existing UIManager signatures as explicit unsupported/no-op compatibility overrides, and simplify native surface tracking to weak Java-owned SurfaceHandlers. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D124979204
Summary: The legacy bridge can no longer be initialized, and the native bridge+Fabric surface path was removed by the parent diff. Remove the corresponding View-based lifecycle APIs from `UIManager`, `FabricUIManager`, and `UIManagerModule`, along with their throwing implementations and unreachable `ReactInstanceManager` call paths. The supported `SurfaceHandlerBinding` lifecycle remains unchanged. Changelog: [Android][Breaking] - Remove legacy View-based surface lifecycle methods from `UIManager`, `FabricUIManager`, and `UIManagerModule`. Reviewed By: christophpurrer Differential Revision: D124983537
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124983537. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The legacy bridge can no longer be initialized, and the native bridge+Fabric surface path was removed by the parent diff. Remove the corresponding View-based lifecycle APIs from
UIManager,FabricUIManager, andUIManagerModule, along with their throwing implementations and unreachableReactInstanceManagercall paths. The supportedSurfaceHandlerBindinglifecycle remains unchanged.Changelog:
[Android][Breaking] - Remove legacy View-based surface lifecycle methods from
UIManager,FabricUIManager, andUIManagerModule.Reviewed By: christophpurrer
Differential Revision: D124983537