Repository navigation
Synchronize native Fantom stub queue - #59015
Closed
Abbondanzo wants to merge 1 commit into
Closed
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
Summary: Fantom’s native `StubQueue` can be written by multiple threads while it is being drained, but its queue access was unsynchronized. Protect queue storage with a mutex while keeping callback invocation and destruction outside the lock, so callbacks can reenter the queue. This is a tester-only change. The single-consumer and queue-lifetime requirements are unchanged; startup readiness and shared runtime teardown are out of scope. Changelog: [Internal] - Synchronize native Fantom stub queue access Differential Revision: D124675719
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124675719. |
|
This pull request has been merged in 8bbd422. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fantom’s native
StubQueuecan be written by multiple threads while it is being drained, but its queue access was unsynchronized. Protect queue storage with a mutex while keeping callback invocation and destruction outside the lock, so callbacks can reenter the queue.This is a tester-only change. The single-consumer and queue-lifetime requirements are unchanged; startup readiness and shared runtime teardown are out of scope.
Changelog:
[Internal] - Synchronize native Fantom stub queue access
Differential Revision: D124675719