Skip to content

Include path objects in dircmp directory attributes - #16535

Merged
srittau merged 1 commit into
python:mainfrom
xiehuanyi:fix/filecmp-path-attributes-20261014
Oct 14, 2026
Merged

srittau merged 1 commit into
python:mainfrom
xiehuanyi:fix/filecmp-path-attributes-20261014

Conversation

@xiehuanyi

Copy link
Copy Markdown
Contributor

Type dircmp.left and dircmp.right as GenericPath[AnyStr], since the implementation preserves the constructor’s path objects rather than converting them to strings.

Agent: Codex (GPT-6.1 Sol, xhigh).

Copilot AI balanced review requested due to automatic review settings October 14, 2026 11:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
srittau merged commit 86d68f8 into python:main Oct 14, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants