Skip to content

Feature the Windows manifest for Python 3.16+ releases #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 2 commits into from
Oct 14, 2026
Merged

Feature the Windows manifest for Python 3.16+ releases #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
431447e
Feature Windows manifest for Python 3.16 and later
savannahostrowski Oct 13, 2026
6a30b07
Merge branch 'main' into fix-windows-manifest-download-button
savannahostrowski Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def get_file_descriptions(
(
"Windows release manifest",
"windows",
False,
v >= (3, 16),
f"Install with 'py install {v[0]}.{v[1]}'",
),
),
Expand Down
25 changes: 25 additions & 0 deletions tests/test_add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,3 +284,28 @@ def test_list_files(fs: FakeFilesystem) -> None:
"Install with 'py install 3.14'",
),
]


@pytest.mark.parametrize(
("release", "expected_download_button"),
[
("3.15.0a1", False),
("3.16.0a1", True),
],
)
def test_windows_manifest_download_button(
fs: FakeFilesystem, release: str, expected_download_button: bool
) -> None:
ftp_root = "/fake_ftp_root"
filename = f"windows-{release}.json"
fs.create_file(Path(ftp_root) / add_to_pydotorg.base_version(release) / filename)

assert list(add_to_pydotorg.list_files(ftp_root, release)) == [
(
filename,
"Windows release manifest",
"windows",
expected_download_button,
f"Install with 'py install {add_to_pydotorg.minor_version(release)}'",
)
]
Loading