Repository navigation
gh-157384: Set package context in PyImport_CreateModuleFromInitfunc() - #157387
Merged
Merged
Conversation
…func() A single-phase init function that creates its module using only the last component of a dotted name (as pybind11 does for submodules) got a module whose __name__ was the short name. Set the package context while calling the init function, as the dynamic loader does, so the module gets the full name from the spec. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HoZE3WdRWQshvinfBZ137N
itamaro
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
kumaraditya303,
ncoghlan and
warsaw
as code owners
September 13, 2026 01:41
4 tasks
Documentation build overview
111 files changed ·
|
Member
|
Would it be possible to fix the binding generator instead? |
Contributor
Author
In what way? afaik pybind11 3+ already defaults to multi-phase init, so this issue is mostly with older pybind11 extensions (2.13 and older), or hand-written C extensions. this fix makes this API honor the documented cpython contract for single-phase init extensions. |
Member
|
Ah, I see. I'm looking at this in detail now. This PR works as something to backport (to 3.15.1 at this point, which should be only a small inconvenience for embedders). But before merging, I'd like to settle on a bigger refactoring for 3.16; perhaps we'll find more to backport. Could I ask you to take a look at #157758? |
Contributor
Author
reviewed your PR - looks like a great refactor! left some comments there, but I don't think there's anything else worth backporting in addition to this PR (and maybe gh-157389). I agree about the backport targeting 3.15.1 and not 3.15.0. |
Member
|
I'll get back to this after the 3.15 release -- fix a few wording nitpicks & merge. |
Contributor
Author
|
@encukou happy post-3.15.0-release! :) should we get this merged now? what nitpicks did you want to change? |
encukou
approved these changes
Oct 13, 2026
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
should we get this merged now? what nitpicks did you want to change?
Yep. Just docs in the end, sorry for the wait.
encukou
enabled auto-merge (squash)
October 13, 2026 13:02
|
GH-159316 is a backport of this pull request to the 3.15 branch. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single-phase init function that creates its module using only the last component of a dotted name (as pybind11 does for submodules) got a module whose name was the short name. Set the package context while calling the init function, as the dynamic loader does, so the module gets the full name from the spec.
AI assisted with Claude Fable 5.1
PyImport_CreateModuleFromInitfunc(): wrong__name__for submodules, non-ASCII names rejected, inittab name clashes #157384