Skip to content

gh-156764: Fix safety configure option defaults - #156767

Open
lpyu001 wants to merge 9 commits into
python:mainfrom
lpyu001:configure
Open

lpyu001 wants to merge 9 commits into
python:mainfrom
lpyu001:configure

Conversation

@lpyu001

@lpyu001 lpyu001 commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Preserve the default enabled safety configuration while correctly handling enable, disable, and invalid values for both safety options.

Preserve the default enabled safety configuration while correctly handling enable, disable, and invalid values for both safety options.
@lpyu001

lpyu001 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Hi, could you take a look at this PR when you get a chance @corona10

@read-the-docs-community

read-the-docs-community Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35169172 | 📁 Comparing f40d7d4 against main (a6b4aa6)

  🔍 Preview build  

3 files changed
± using/configure.html
± whatsnew/3.14.html
± whatsnew/changelog.html

@lpyu001

lpyu001 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

I've updated this PR. Both options now stay disabled by default, as decided in gh-124064.

  • configure.ac / configure: use $enableval, so --disable-safety and --disable-slower-safety no longer enable the options. Invalid values are rejected.
  • Doc/using/configure.rst and Doc/whatsnew/3.14.rst: document --enable-safety (off by default) instead of the old --disable-safety.

This affects 3.14 and 3.15 as well, so it should be backported.

@lpyu001

lpyu001 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

cc @AA-Turner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant