Repository navigation
gh-154320: Fix swapped __defaults__/__kwdefaults__ in annotationlib docs - #154321
Merged
JelleZijlstra merged 1 commit intoJul 21, 2026
Merged
JelleZijlstra merged 1 commit into
JelleZijlstra merged 1 commit into
Conversation
…nlib docs The bullet list under "Creating a custom callable annotate function" had the attribute names reversed: positional defaults are __defaults__ (a tuple) and keyword defaults are __kwdefaults__ (a dict). The example code below was already correct. Fixes python#154320
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
|
JelleZijlstra
added
needs backport to 3.14
JelleZijlstra
enabled auto-merge (squash)
July 21, 2026 12:45
|
Thanks @Solaris-star for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-154350 is a backport of this pull request to the 3.15 branch. |
|
GH-154351 is a backport of this pull request to the 3.14 branch. |
encukou
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 13, 2026
…nlib docs (pythonGH-154321) The bullet list under "Creating a custom callable annotate function" had the attribute names reversed: positional defaults are __defaults__ (a tuple) and keyword defaults are __kwdefaults__ (a dict). The example code below was already correct. Fixes pythonGH-154320 (cherry picked from commit dc72be1)
encukou
pushed a commit
that referenced
this pull request
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Doc/library/annotationlib.rst, under Creating a custom callable annotate function, the bullet list swapped attribute names:__kwdefaults____defaults__Correct Python semantics:
__defaults__— tuple of positional defaults__kwdefaults__— dict of keyword-only defaultsThe example class body already used the correct attributes; only the prose was wrong.
Linked Issue
Closes #154320