Repository navigation
Remove un-necessary socket requirements in async tests #128404
Description
Proposal:
the builtins async tests should run coroutines using coro.send(None) because they don't need an async framework to run. This would remove asyncio from the tests and support running on emscripten/wasi
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
Linked PRs
- gh-128404: remove asyncio from test_builtin #128403
- gh-128404: remove asyncio from test_sys_settrace #128435
- gh-128404: remove asyncio from test_type_params #128436
- gh-128404: split test_asyncgen.py into tests that require a working socket and tests that do not #128443
- gh-128404: Run TestGetAsyncGenState without asyncio #156808
Activity
gh-128404: Remove ``asyncio`` from ``test_builtin`` (#128403)
Eclips4 commentedon Jan 2, 2025
@graingert Are there many other tests that rely on the
asyncioframework that in fact shouldn't rely on it?If so, let's reuse this issue for them.
graingert commentedon Jan 2, 2025
I think there's only 3-4 files left.
The last ones I want to touch are test_coroutine.py and test_asyncgens.py because they need a bit of thought. I'd like them split into using framework free code to test the object, and tests that test how asyncio interact with the object moved into test_asyncio. This will involve some duplication I think.
Eclips4 commentedon Jan 2, 2025
Let's now use this issue, and later create issues for
test_coroutine&test_asyncgens.[-] Remove un-necessary socket requirements in builtins async tests[/-][+] Remove un-necessary socket requirements in async tests[/+]pythongh-128404: remove asyncio from test_sys_settrace
pythongh-128404: remove asyncio from test_type_params
gh-128404: remove asyncio from test_type_params (#128436)
gh-128404: Remove `asyncio` from `Lib/test/test_sys_settrace` (#128435)
pythongh-128404: remove requires_working_socket from some of test_asy…
graingert commentedon Jan 4, 2025
I've gone with this issue currently, for test_asyngens as it's currently a relatively minor rearrangement to start with. I'll do another issue for duplicating auditing the tests that still use asyncio.run/loop.run_until_complete and creating tests that work on wasi etc, while keeping the tests that verify the asyncio integration
pythongh-128404: Remove `asyncio` from `Lib/test/test_sys_settrace` (p…
pythongh-128404: Remove ``asyncio`` from ``test_builtin`` (python#128403
pythongh-128404: remove asyncio from test_type_params (python#128436)
pythongh-128404: Remove `asyncio` from `Lib/test/test_sys_settrace` (p…
pythongh-128404: remove requires_working_socket from some of test_asy…
pythongh-128404: remove requires_working_socket from some of test_asy…