Skip to content

ci: Update plotly.js fetch location - #5815

Merged
camdecoster merged 2 commits into
mainfrom
cam/5814/update-plotly.js-fetch-location
Oct 15, 2026
Merged

camdecoster merged 2 commits into
mainfrom
cam/5814/update-plotly.js-fetch-location

Conversation

@camdecoster

@camdecoster camdecoster commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Link to issue

Closes #5814.

Description of change

Remove the dependency on the committed plotly.js dist/ folder.

Testing strategy

I ran updateplotlyjs for version 4.1.1, and it reproduced the committed files byte-for-byte. I ran codegen and the core tests against the schema on plotly.js main, and they passed.

Additional information (optional)

  • updateplotlyjs now downloads plotly.min.js and plot-schema.json from the npm package and verifies the npm checksum
  • updateplotlyjsdev now accepts only a local plotly.js path (remote mode was removed)
  • The new test-plotlyjs-dev.yml workflow replaces the per-PR "plotly.js dev build" job. It runs once a week and opens an issue if a scheduled run fails.
  • This PR stops building the dev wheel artifact. We can add it back if there is demand.
  • This update is in service of removing the dist folder from the plotly.js repo

Guidelines

@camdecoster camdecoster added the no-changelog A changelog entry is not required for this PR label Oct 15, 2026

@KoolADE85 KoolADE85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I note that we have this issue plotly/plotly.js#7747 still open and we may want to close it now that this PR answers that question.

@camdecoster

Copy link
Copy Markdown
Contributor Author

That will have to be closed once we actually remove it from plotly.js, but good call.

@camdecoster
camdecoster merged commit c6ab9c7 into main Oct 15, 2026
32 of 33 checks passed
@camdecoster
camdecoster deleted the cam/5814/update-plotly.js-fetch-location branch October 15, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog A changelog entry is not required for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE]: Stop depending on the committed plotly.js dist/ folder

2 participants