Repository navigation
ci: Update plotly.js fetch location - #5815
Merged
Merged
Conversation
KoolADE85
approved these changes
Oct 15, 2026
KoolADE85
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
I note that we have this issue plotly/plotly.js#7747 still open and we may want to close it now that this PR answers that question.
Contributor
Author
|
That will have to be closed once we actually remove it from plotly.js, but good call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5814.
Description of change
Remove the dependency on the committed plotly.js
dist/folder.Testing strategy
I ran
updateplotlyjsfor version 4.1.1, and it reproduced the committed files byte-for-byte. I ran codegen and the core tests against the schema on plotly.jsmain, and they passed.Additional information (optional)
updateplotlyjsnow downloadsplotly.min.jsandplot-schema.jsonfrom the npm package and verifies the npm checksumupdateplotlyjsdevnow accepts only a local plotly.js path (remote mode was removed)test-plotlyjs-dev.ymlworkflow replaces the per-PR "plotly.js dev build" job. It runs once a week and opens an issue if a scheduled run fails.Guidelines