Skip to content

Restore numpy in sys.modules after test_no_numpy_int_type #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhaoruizhe81 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −8
Open

Restore numpy in sys.modules after test_no_numpy_int_type #5807

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d973f3b
Restore numpy in sys.modules after test_no_numpy_int_type
zhaoruizhe81 Oct 10, 2026
b8025f0
Apply review feedback: switch to mock-based approach and drop changel…
zhaoruizhe81 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions tests/test_optional/test_utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,14 +487,11 @@ def test_get_numpy_int_type(self):
class TestNoNumpyIntegerBaseType(TestCase):
def test_no_numpy_int_type(self):
import sys
from unittest import mock
from _plotly_utils.utils import _get_int_type
from _plotly_utils.optional_imports import get_module

np = get_module("numpy", should_load=False)
if np:
sys.modules.pop("numpy")
with mock.patch.dict(sys.modules, {"numpy": None}):
int_type_tuple = _get_int_type()
expected_tuple = (int,)

int_type_tuple = _get_int_type()
expected_tuple = (int,)

self.assertEqual(int_type_tuple, expected_tuple)
self.assertEqual(int_type_tuple, expected_tuple)