Repository navigation
chore: remove "official"/"unofficial" language for installation methods #9210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
9e805b7
923f287
25bb4e3
030239c
3bbd651
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -241,8 +241,8 @@ | |
| "packageManager": "مدير الحزم", | ||
| "unknown": "غير معروف", | ||
| "platformGroups": { | ||
| "official": "موصى به (رسمي)", | ||
| "unofficial": "المجتمع (غير رسمي)" | ||
| "recommended": "موصى به", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As far as I know, we only need to update the English strings (en.json). Other locales like ar.json are synced from Crowdin, so changes there should go through Crowdin instead. See: https://github.com/nodejs/nodejs.org/blob/main/docs/translation.md#adding-new-translation-keys
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeh, these would then become untranslated new keys, though, burning the existing translations that have been done. I left a note about this in the PR description, whether it is possible for us to directly update the existing translation key/values, to avoid wasting those translations and having these become untranslated again. |
||
| "community": "المجتمع" | ||
| } | ||
| }, | ||
| "codeBox": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol