Skip to content

build: warn on incompatible quic configure flags #66754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

build: warn on incompatible quic configure flags #66754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2450,8 +2450,19 @@ def configure_ffi(o):
configure_library('ffi', o, pkgname='libffi')

def configure_quic(o):
o['variables']['node_use_quic'] = b(options.experimental_quic and
not options.without_ssl)
if options.experimental_quic and options.without_ssl:
warn('--experimental-quic is incompatible with --without-ssl')
o['variables']['node_use_quic'] = b(options.experimental_quic)

if not options.experimental_quic:
for lib in ['nghttp3', 'ngtcp2']:
shared_lib = 'shared_' + lib
if getattr(options, shared_lib):
warn(f'--shared-{lib} requires --experimental-quic')
return

configure_library('nghttp3', output, pkgname='libnghttp3')
configure_library('ngtcp2', output, pkgname='libngtcp2')

def configure_dtls(o):
o['variables']['node_use_dtls'] = b(options.experimental_dtls and
Expand Down Expand Up @@ -2974,8 +2985,6 @@ def make_bin_override():
configure_library('merve', output)
configure_library('nbytes', output)
configure_library('nghttp2', output, pkgname='libnghttp2')
configure_library('nghttp3', output, pkgname='libnghttp3')
configure_library('ngtcp2', output, pkgname='libngtcp2')
configure_lief(output);
configure_perfetto(output);
configure_sqlite(output);
Expand Down
Loading