Skip to content

vfs: allow mounting in permission audit mode - #66745

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:allow-mounting-in-permission-audit-mode
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:allow-mounting-in-permission-audit-mode

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

vfs: allow mounting in permission audit mode

vfs.mount() threw ERR_INVALID_STATE under --permission-audit unless --allow-fs-vfs was also passed, because permission.isEnabled() is true in audit mode too.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Oct 15, 2026
@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model. label Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.48%. Comparing base (782a3ac) to head (162d245).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/vfs/setup.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66745   +/-   ##
=======================================
  Coverage   90.47%   90.48%           
=======================================
  Files         791      791           
  Lines      277225   277227    +2     
  Branches    53313    53323   +10     
=======================================
+ Hits       250829   250840   +11     
+ Misses      16801    16800    -1     
+ Partials     9595     9587    -8     
Files with missing lines Coverage Δ
lib/internal/vfs/setup.js 87.06% <33.33%> (-0.07%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants