Skip to content

child_process: copy split permission flag values - #66725

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:child-process-copy-split-permission-flag-values
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:child-process-copy-split-permission-flag-values

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

child_process: copy split permission flag values

List permission flags passed as --allow-fs-read /tmp were copied to the child's NODE_OPTIONS without their value, so the child failed with "requires an argument". Values with spaces were not quoted either.

The value is now read from process.execArgv in both the split and the --flag=value forms, and quoted.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.47%. Comparing base (dd7235c) to head (5d8623b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/child_process.js 3.57% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66725      +/-   ##
==========================================
- Coverage   90.48%   90.47%   -0.02%     
==========================================
  Files         791      791              
  Lines      277204   277224      +20     
  Branches    53311    53319       +8     
==========================================
- Hits       250841   250825      -16     
- Misses      16760    16811      +51     
+ Partials     9603     9588      -15     
Files with missing lines Coverage Δ
lib/child_process.js 89.92% <3.57%> (-1.48%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model. label Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants