Skip to content

benchmark: fix hideStackFrames error benchmarks #66723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RafaelGSS wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

benchmark: fix hideStackFrames error benchmarks #66723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmark/error/hidestackframes-noerr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ function main({ n, type }) {

const hideStackFramesTestfn = hideStackFrames((value) => {
if (typeof value !== 'number') {
throw new ERR_INVALID_ARG_TYPE.HideStackFrameError('Benchmark', 'number', value);
throw new ERR_INVALID_ARG_TYPE.HideStackFramesError('Benchmark', 'number', value);
}
});

const fn = type === 'hide-stackframe' ? hideStackFramesTestfn : testfn;
const fn = type === 'hide-stackframes' ? hideStackFramesTestfn : testfn;

const value = 42;

Expand Down
4 changes: 2 additions & 2 deletions benchmark/error/hidestackframes-throw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function main({ n, type, double }) {

const hideStackFramesTestfn = hideStackFrames((value) => {
if (typeof value !== 'number') {
throw new ERR_INVALID_ARG_TYPE.HideStackFrameError('Benchmark', 'number', value);
throw new ERR_INVALID_ARG_TYPE.HideStackFramesError('Benchmark', 'number', value);
}
});

Expand All @@ -44,7 +44,7 @@ function main({ n, type, double }) {
hideStackFramesTestfn.withoutStackTrace(value);
});

const fn = type === 'hide-stackframe' ?
const fn = type === 'hide-stackframes' ?
double === 'true' ?
doubleHideStackFramesTestfn :
hideStackFramesTestfn :
Expand Down
Loading