Repository navigation
Conversation
Reserve the source port with a dual-stack listener and keep it open until the destination server is listening. This prevents choosing an occupied IPv6 port or letting the destination reuse the source port. Refs: nodejs/reliability#1686 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Retry attempts that did not reach the blocked Worker before parsing their report. A timeout during startup can force exit before the report is complete. Keep the report and exit assertions once startup is ready. Refs: nodejs/reliability#1687 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
The self-directed debug signal restarts the inspector asynchronously. Wait for the replacement server to listen before asking the child to exit, instead of racing startup against a zero-delay timer. Refs: nodejs/reliability#1687 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Keep the event loop alive until the periodic write drains and let the test runner enforce the timeout. A one-second deadline can expire while asynchronous file I/O is still pending on a busy CI machine. Refs: nodejs/reliability#1690 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
The oversized-string cases allocate hundreds of megabytes and can make the ordinary statement test time out under parallel suite load. Move all five cases unchanged to the sequential pummel suite, which also allows more time for intensive tests. Refs: nodejs/reliability#1690 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Ten thousand non-blocking loop turns can finish before the Worker has started. Use a thirty-second deadline and yield between turns while waiting for its exit, preserving the expected exit-code assertion. Refs: nodejs/reliability#1687 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
flaky-test
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Collaborator
aduh95
approved these changes
Oct 14, 2026
jasnell
approved these changes
Oct 14, 2026
panva
added
the
author ready
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66722 +/- ##
==========================================
- Coverage 90.48% 90.47% -0.02%
==========================================
Files 791 791
Lines 277204 277204
Branches 53311 53310 -1
==========================================
- Hits 250841 250788 -53
- Misses 16760 16812 +52
- Partials 9603 9604 +1 🚀 New features to boost your workflow:
|
panva
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deflake tests appearing in the October 10–14 reliability reports:
parallel/test-net-autoselectfamily-local-portreport/test-report-process-timeout-workerparallel/test-inspector-debug-endparallel/test-fastutf8stream-periodicflushparallel/test-sqlite-statementSharedIsolateTest.EnvironmentsComeAndGoWhileSiblingsRunRefs: nodejs/reliability#1686
Refs: nodejs/reliability#1687
Refs: nodejs/reliability#1690
Assisted-by: Codex