Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions doc/contributing/maintaining/maintaining-V8.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,26 @@ fixed upstream first.
branches that are still active or are branches that Node.js cares about.
Follow the process for backporting below.

### Backporting patches to `main`

As a general rule, do not backport individual V8 patches to the Node.js `main`
branch. Wait for them to be included in a V8 major version update instead.
An individual V8 patch adds up audit cost and further delays the pending V8
update.

A patch may be backported to `main` when at least one of these criteria applies:

* It fixes a build issue on a platform or toolchain supported on `main`.
* It fixes a security issue.
* It unblocks a pending V8 update, for example by adjusting how the Node.js code
uses a V8 API so that it works with the future update.

If the patch meet the following criteria, it's recommended to backport the patches
to the release staging branches like `v<MAJOR>.x-staging`, instead of `main`:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also remind folks that we typically don't accept PRs targeting LTS staging branches?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like suggest words? I didn't find any docs saying the criteria on backporting dependency patches specifically.


* It has demonstrated real-world urgency and impact that justifies landing it
before the next V8 major version update.

### Backporting to active branches

If the bug exists in any of the active V8 branches, we may need to get the fix
Expand Down
Loading