crypto: do not leak scrypt param check errors

[lazerg]

Fixes: #66668

When checkScryptParams() fails on the memory check, OpenSSL queues an error. ScryptTraits::AdditionalConfig() only peeks at it to build the message and leaves it on the queue, so the next unrelated call on the thread, like createPrivateKey() with a valid key, throws ERR_OSSL_EVP_MEMORY_LIMIT_EXCEEDED.

This pops the error with MarkPopErrorOnReturn once the check is done. The thrown message stays the same.

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[github-actions]

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (3b639be) to head (cd7d6f8).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66671      +/-   ##
==========================================
- Coverage   92.82%   90.47%   -2.35%     
==========================================
  Files         422      791     +369     
  Lines      194189   277089   +82900     
  Branches    30027    53271   +23244     
==========================================
+ Hits       180249   250690   +70441     
- Misses      13614    16812    +3198     
- Partials      326     9587    +9261     

Files with missing lines	Coverage Δ
src/crypto/crypto_scrypt.cc	73.07% <100.00%> (ø)

... and 499 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78330/

[github-actions]

Failed to resume CI

✖  Cannot resume PR CI job 78330: Jenkins does not offer a "Resume build" action. Check the existing CI run in Jenkins and rebase the PR if needed. To start a new CI run manually: ncu-ci run https://github.com/nodejs/node/pull/66671
   ✖  https://ci.nodejs.org/job/node-test-pull-request/78330/

Full Auto Start CI output

�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 66671
�[36m⠙�[39m Looking for CI runs for pull request 66671
�[36m⠙�[39m Getting PR from nodejs/node/pull/66671
�[36m⠙�[39m Getting reviews from nodejs/node/pull/66671
�[36m⠙�[39m Getting comments from nodejs/node/pull/66671
✔  Found PR CI job 78330
�[36m⠹�[39m Querying data for job/node-test-pull-request/78330/
�[36m⠹�[39m Querying data for job/node-test-pull-request/78330/
�[36m⠹�[39m Querying API for job/node-test-pull-request/78330/
✔  Build data downloaded
�[36m⠹�[39m Checking whether PR CI job 78330 can be resumed
�[36m⠹�[39m Checking whether PR CI job 78330 can be resumed
✖  Cannot resume PR CI job 78330: Jenkins does not offer a "Resume build" action. Check the existing CI run in Jenkins and rebase the PR if needed. To start a new CI run manually: ncu-ci run https://github.com/nodejs/node/pull/66671
   ✖  https://ci.nodejs.org/job/node-test-pull-request/78330/

View workflow run

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78343/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78349/