Skip to content

fix(client): avoid quadratic buffering in stdio_client stdout reader - #3706

Closed
maxiaochaos wants to merge 1 commit into
modelcontextprotocol:mainfrom
maxiaochaos:cursor/stdio-linear-line-buffer-bfc1
Closed

maxiaochaos wants to merge 1 commit into
modelcontextprotocol:mainfrom
maxiaochaos:cursor/stdio-linear-line-buffer-bfc1

Conversation

@maxiaochaos

Copy link
Copy Markdown

stdout_reader was doing (buffer + chunk).split on every chunk, so one big single-line response got copied over and over (O(N²)).

Now partial pieces sit in a list and only get joined when a newline shows up. Line splitting is the same as before.

Added a regression test: an 8 MiB JSON line fed in 1 KiB chunks parses as one message, and the next message still frames fine.

Fixes #3699

stdout_reader rebuilt the whole buffer on every chunk, so one big JSON
line was copied once per read. Keep unfinished pieces in a list and join
them once a newline arrives.

Co-authored-by: maxiaochaos <maxiaochaos@users.noreply.github.com>
@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3699.

If a maintainer assigns you to #3699, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stdio_client: receiving a large response takes quadratic time (buffer + chunk is re-copied for every chunk)

1 participant