Repository navigation
fix(client): avoid quadratic buffering in stdio_client stdout reader - #3705
maxiaochaos wants to merge 1 commit into
Conversation
stdout_reader rebuilt the whole buffer on every chunk, so one big JSON line was copied once per read. Keep unfinished pieces in a list and join them once a newline arrives. Co-authored-by: maxiaochaos <maxiaochaos@users.noreply.github.com>
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3699. If a maintainer assigns you to #3699, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
stdout_reader was doing (buffer + chunk).split on every chunk, so one big single-line response got copied over and over (O(N²)).
Now partial pieces sit in a list and only get joined when a newline shows up. Line splitting is the same as before.
Added a regression test: an 8 MiB JSON line fed in 1 KiB chunks parses as one message, and the next message still frames fine.
Fixes #3699