Repository navigation
[Server] Answer an unavailable session lock like an unavailable session store - #603
Merged
chr-hertel merged 1 commit intoOct 15, 2026
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 14, 2026 23:48
chr-hertel
added
Server
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves timeout behavior and includes matching test assertions and documentation updates.
0 open findings
What changed in this PR
Aligns unavailable session-lock responses with session-store failures while preserving busy-session behavior.
Changes:
- Returns JSON-RPC
-32603with “Session lock is unavailable.” for backend failures, retaining HTTP503. - Updates regression assertions and documentation; busy sessions remain
-32000.
| File | Description |
|---|---|
| tests/Unit/Server/ProtocolSessionLockTest.php | Updates expected error code and message. |
| src/Server/Protocol.php | Distinguishes backend failures from busy-session errors. |
| docs/run/sessions.md | Documents the revised failure message. |
| CHANGELOG.md | Records alignment with session-store failures. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #570 & #584: both answer an unavailable backend with
503, but in two dialects - a failing session store with-32603"Session store is unavailable.", a failing session lock with-32000"The session lock is unavailable.".-32603and "Session lock is unavailable.", same as the store and the lock's own log line-32000"Another request of this session is still being processed."Both are unreleased, so nothing breaks.