Repository navigation
Forward port 2.1.x main - #1188
Merged
Merged
Conversation
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
mcp's module-info refers to sibling modules by their JPMS names, which only exist once those modules are packaged as jars. Before the package phase, the reactor passes bare target/classes directories, which can't be automatic modules. So mcp is compiled at prepare-package. javadoc:aggregate forks a compile-phase build of the whole reactor, so the fork never produces mcp classes. Modules that depend on mcp at compile scope (the conformance tests) then fall back to Maven Central, where the release version doesn't exist yet. The conformance tests are not deployed, so leave them out of the release build. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
forward-port-2.1.x-main
branch
from
October 15, 2026 16:47
502644c to
8512a84
Compare
The ubuntu-24.04 runner image now ships Maven 3.10, where the staging
metadata is written as maven-metadata-local.xml. central-publishing
0.7.0 only removes maven-metadata-central-staging.xml before bundling,
so the leftover files end up in the bundle and Central rejects it
("Bundle has content that does NOT have a .pom file").
Use ./mvnw everywhere, so CI runs the Maven version pinned in
maven-wrapper.properties instead of whatever the runner image ships.
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
forward-port-2.1.x-main
branch
from
October 15, 2026 17:06
8512a84 to
05d6ebf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.