Repository navigation
Add noEmit to BuildOrchestrator overrideCompilerOptions - #64759
Open
Elecmonkey (elecmonkey) wants to merge 2 commits into
Open
Elecmonkey (elecmonkey) wants to merge 2 commits into
Elecmonkey (elecmonkey) wants to merge 2 commits into
Conversation
Also fix CreateBuildOrchestratorParams so that its embedded BuildOptions and CompilerOptions are inlined when unmarshalling. The client sends these options flat (matching the generated protocol types), but the json name tags made the server expect them nested, so all build and override options were silently dropped.
typescript-automation
Bot
added
the
For Uncommitted Bug
Author
|
@microsoft-github-policy-service agree |
Elecmonkey (elecmonkey)
marked this pull request as ready for review
October 13, 2026 03:11
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64158: adds
noEmittoOverrideCompilerOptionsforcreateBuildOrchestrator.This also fixes
CreateBuildOrchestratorParamson the Go side. The embeddedBuildOptions/CompilerOptionshad JSON name tags, so the flattened options sent by the client were ignored. The existing test'sdeclaration: falseon composite projects now correctly errors (TS6304), so it usesdeclaration: true.