Repository navigation
fix: accept space-separated toolchain remove specs - #808
Open
dannyward630 wants to merge 2 commits into
Open
dannyward630 wants to merge 2 commits into
dannyward630 wants to merge 2 commits into
Conversation
…missing `remove` does not resolve a partial version the way `default` does (no resolve_version_match): `mcpp toolchain remove gcc 15` with 15.1.0 installed reports "gcc@15 is not installed". The help no longer claims a partial version works. A removal deletes one payload, so it names that payload. A family with no version (`mcpp toolchain remove gcc`) still printed "invalid spec 'gcc'", the message mcpp-community#284 reports as reading like a wrong family name. A spec the parser rejects now carries the parser's own reason, as `default` does, and a family alone says the exact version is missing. e2e 26 asserts the missing-version message and drops the repeated `install gcc@16.1.0`, which only re-ran an install that was already done.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpp toolchain remove <family> <version>alongside the existingfamily@versionform.defaultand pass both positional values through the shared toolchain spec parser.--target.Closes #284
Test plan
mcpp build --strictpassed.mcpp testpassed: 150 targets; root DAC override was dropped for the permission-denial test.tests/e2e/26_toolchain_management.shpassed with the fresh binary.