Repository navigation
fix(datetime): re-process value in componentDidLoad if present - #31593
Open
rudrakshagarwal4200-ai wants to merge 1 commit into
Open
rudrakshagarwal4200-ai wants to merge 1 commit into
rudrakshagarwal4200-ai wants to merge 1 commit into
Conversation
Added a check to re-process value if assigned before componentDidLoad.
|
@rudrakshagarwal4200-ai is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31565.
With standalone components under Angular /
zone.js,NgModelwritesvaluein a resolved-promise microtask after the element is connected. Because the Stencil runtime does not set the watch-ready flag until the nativecustomElements.whenDefined()promise resolves,@Watch('value')is missed for values assigned during that microtask window. Consequently,workingPartsdefaults to current time, and the wheels open on the current time rather than the bound value.Fix
In
componentDidLoad(), checkif (this.hasValue()) { this.processValue(this.value); }. This ensures any value set before load is properly evaluated, updatingworkingPartsand wheel indices to the bound value.