Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30361
What is the current behavior?
In v8, using
ion-tab-barwithoution-tabsthrows in Vue becauseIonTabBarinjectstabBarDatawith no default and reads.valueoffundefined. Clicking a tab button then throws again in the native event handler. This was already fixed in v9 by the strict type checking chore in #31320, which gave the injection anulldefault and guarded it, but nothing tests the standalone case in a browser.What is the new behavior?
This adds a
/tabs-standalonepage to the Vue test app with anion-tab-barthat has noion-tabsorion-router-outletaround it, where the app tracks the active tab itself and navigates by callingrouter.pushfrom the tab buttons. The new Playwright spec checks that clicking moves the selected state, runs the app's own@click, doesn't change the URL, logs no errors or warnings, and thatrouter.pushfrom a tab button navigates.Does this introduce a breaking change?
Other information
I checked that the spec catches the original bug by patching the built
@ionic/vueback to the v8inject("tabBarData"). Both tests fail with the errors from the issue, and they pass on this branch. This is test-only, so the v8 behavior is unchanged. We aren't backporting the fix since it isn't critical.The follow-up request in the issue for a page animation when switching tabs by method isn't covered here and is out of scope for the issue it's in.