Repository navigation
fix(showcase): update parent context retry tests for operation span in ITOtelTracing - #14673
Open
jinseopkim0 wants to merge 1 commit into
Open
jinseopkim0 wants to merge 1 commit into
jinseopkim0 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenTelemetry tracing integration tests in ITOtelTracing.java for both gRPC and HTTP/JSON retry scenarios. It introduces verification for an intermediate operation span (google.showcase.v1beta1.Echo.Echo) that acts as a parent to the individual attempt spans, rather than having the attempt spans link directly to the root parent span. I have no feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
testTracing_retry_grpc_linkedToParentContextandtestTracing_retry_httpjson_linkedToParentContextinITOtelTracingto account for the operation-level span introduced in #14549 and wait for asynchronous span completion usingwaitForSpans.b/541322523