Repository navigation
Conversation
`pnpm check` (the command CONTRIBUTING tells contributors to run before pushing) ran only formatting and linting, while CI also runs `tsc --noEmit` in a separate step. So a local `pnpm check` could pass and CI then fail on a type error. Fold `vp exec tsc --noEmit` into `check` and `check:fix`, reusing the exact command CI runs. `CONTRIBUTING.md` already names `pnpm check`, so no doc change is needed; CI's `vp run check` (lint.yml) now type-checks too.
|
setchy
marked this pull request as draft
October 14, 2026 11:54
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the standard check command type-check the codebase, closing the gap between the documented local pre-PR command and CI.
check→vp check && vp exec tsc --noEmit;check:fixlikewise.test.ymlalready runs.CONTRIBUTING.mdalready namespnpm check, so its guidance becomes accurate rather than changing — and because CI'slint.ymlrunsvp run check, that job now type-checks too.No production code change.
Verification
pnpm checkon a clean tree — format + lint + type-check all passconst x: number = 'not a number') —pnpm checknow fails (exit 1) withTS2322; probe removedpnpm test— 188 files, 1901 tests passing