Repository navigation
fix(github): catch network ReadTimeout - #308
Merged
Merged
Conversation
Today we got a
ERROR -- : Caught Net::ReadTimeout POSTing to https://api.github.com/graphql: Net::ReadTimeout with #<TCPSocket:(closed)>
This is not worthy of an ERROR; it's safe to just retry.
Turns out we didn't have any rescue for this case, so I've added it.
I've also flattened the file a little bit, having a global rescue list
instead of splitting them.
There was a problem hiding this comment.
🟡 Changes recommended
The timeout path fails to reset the cached connection, and an existing test retains the obsolete ERROR expectation.
2 open findings
What changed in this PR
Handles GitHub GraphQL read timeouts as retryable warnings and bumps the patch version.
Changes:
- Adds
Net::ReadTimeouthandling and coverage. - Flattens exception handling.
- Bumps version to 1.2.6.
| File | Description |
|---|---|
lib/entitlements/service/github.rb |
Handles read timeouts as retryable responses. |
spec/unit/entitlements/service/github_spec.rb |
Adds timeout behavior coverage. |
lib/version.rb |
Bumps the patch version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ayomi-gh
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we got a
This is not worthy of an ERROR; it's safe to just retry.
Turns out we didn't have any rescue for this case, so I've added it.
I've also flattened the file a little bit, having a global rescue list instead of splitting them.