Skip to content

C++: Create quality suite #22811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
geoffw0 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

C++: Create quality suite #22811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5b5c69
C++: Freeze the quality part of the existing cpp-security-and-quality…
geoffw0 Oct 9, 2026
74b3820
C++: Tag the new quality queries.
geoffw0 Oct 9, 2026
4782abb
C++: Add / adjust sub-tags per the guide.
geoffw0 Oct 9, 2026
2bbfe4f
C++: Add more sub-sub-tags.
geoffw0 Oct 12, 2026
e9d40d4
C++: Change note.
geoffw0 Oct 13, 2026
c0d807d
C++: Accept changes to suite tests.
geoffw0 Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions cpp/ql/integration-tests/query-suite/cpp-code-quality-extended.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,46 @@
ql/cpp/ql/src/Best Practices/BlockWithTooManyStatements.ql
ql/cpp/ql/src/Best Practices/ComplexCondition.ql
ql/cpp/ql/src/Best Practices/Exceptions/AccidentalRethrow.ql
ql/cpp/ql/src/Best Practices/Exceptions/CatchingByValue.ql
ql/cpp/ql/src/Best Practices/Exceptions/LeakyCatch.ql
ql/cpp/ql/src/Best Practices/Exceptions/ThrowingPointers.ql
ql/cpp/ql/src/Best Practices/GuardedFree.ql
ql/cpp/ql/src/Best Practices/Hiding/DeclarationHidesParameter.ql
ql/cpp/ql/src/Best Practices/Hiding/DeclarationHidesVariable.ql
ql/cpp/ql/src/Best Practices/Likely Errors/Slicing.ql
ql/cpp/ql/src/Best Practices/RuleOfTwo.ql
ql/cpp/ql/src/Best Practices/UseOfGoto.ql
ql/cpp/ql/src/Critical/LargeParameter.ql
ql/cpp/ql/src/Critical/NewArrayDeleteMismatch.ql
ql/cpp/ql/src/Critical/NewDeleteArrayMismatch.ql
ql/cpp/ql/src/Documentation/FixmeComments.ql
ql/cpp/ql/src/Header Cleanup/Cleanup-DuplicateIncludeGuard.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/BitwiseSignCheck.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/ComparisonPrecedence.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/FloatComparison.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/PointlessComparison.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/PointlessSelfComparison.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/UnsignedGEZero.ql
ql/cpp/ql/src/Likely Bugs/ContinueInFalseLoop.ql
ql/cpp/ql/src/Likely Bugs/Conversion/ArrayArgSizeMismatch.ql
ql/cpp/ql/src/Likely Bugs/Conversion/ImplicitDowncastFromBitfield.ql
ql/cpp/ql/src/Likely Bugs/Format/TooManyFormatArguments.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/AmbiguousAssignmentOfComparison.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/AssignWhereCompareMeant.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/CompareWhereAssignMeant.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/DubiousNullCheck.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/FutileConditional.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/ShortCircuitBitMask.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.ql
ql/cpp/ql/src/Likely Bugs/Memory Management/ReturnCstrOfLocalStdString.ql
ql/cpp/ql/src/Likely Bugs/OO/IncorrectConstructorDelegation.ql
ql/cpp/ql/src/Likely Bugs/OO/NonVirtualDestructorInBaseClass.ql
ql/cpp/ql/src/Likely Bugs/OO/ThrowInDestructor.ql
ql/cpp/ql/src/Likely Bugs/ReturnConstTypeMember.ql
ql/cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql
ql/cpp/ql/src/Likely Bugs/Underspecified Functions/TooManyArguments.ql
ql/cpp/ql/src/jsf/4.07 Header Files/AV Rule 35.ql
ql/cpp/ql/src/jsf/4.10 Classes/AV Rule 71.1.ql
ql/cpp/ql/src/jsf/4.10 Classes/AV Rule 79.ql
ql/cpp/ql/src/jsf/4.24 Control Flow Structures/AV Rule 197.ql
45 changes: 45 additions & 0 deletions cpp/ql/integration-tests/query-suite/cpp-code-quality.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,46 @@
ql/cpp/ql/src/Best Practices/BlockWithTooManyStatements.ql
ql/cpp/ql/src/Best Practices/ComplexCondition.ql
ql/cpp/ql/src/Best Practices/Exceptions/AccidentalRethrow.ql
ql/cpp/ql/src/Best Practices/Exceptions/CatchingByValue.ql
ql/cpp/ql/src/Best Practices/Exceptions/LeakyCatch.ql
ql/cpp/ql/src/Best Practices/Exceptions/ThrowingPointers.ql
ql/cpp/ql/src/Best Practices/GuardedFree.ql
ql/cpp/ql/src/Best Practices/Hiding/DeclarationHidesParameter.ql
ql/cpp/ql/src/Best Practices/Hiding/DeclarationHidesVariable.ql
ql/cpp/ql/src/Best Practices/Likely Errors/Slicing.ql
ql/cpp/ql/src/Best Practices/RuleOfTwo.ql
ql/cpp/ql/src/Best Practices/UseOfGoto.ql
ql/cpp/ql/src/Critical/LargeParameter.ql
ql/cpp/ql/src/Critical/NewArrayDeleteMismatch.ql
ql/cpp/ql/src/Critical/NewDeleteArrayMismatch.ql
ql/cpp/ql/src/Documentation/FixmeComments.ql
ql/cpp/ql/src/Header Cleanup/Cleanup-DuplicateIncludeGuard.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/BitwiseSignCheck.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/ComparisonPrecedence.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/FloatComparison.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/PointlessComparison.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/PointlessSelfComparison.ql
ql/cpp/ql/src/Likely Bugs/Arithmetic/UnsignedGEZero.ql
ql/cpp/ql/src/Likely Bugs/ContinueInFalseLoop.ql
ql/cpp/ql/src/Likely Bugs/Conversion/ArrayArgSizeMismatch.ql
ql/cpp/ql/src/Likely Bugs/Conversion/ImplicitDowncastFromBitfield.ql
ql/cpp/ql/src/Likely Bugs/Format/TooManyFormatArguments.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/AmbiguousAssignmentOfComparison.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/AssignWhereCompareMeant.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/CompareWhereAssignMeant.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/DubiousNullCheck.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/FutileConditional.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/ShortCircuitBitMask.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/UsingStrcpyAsBoolean.ql
ql/cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.ql
ql/cpp/ql/src/Likely Bugs/Memory Management/ReturnCstrOfLocalStdString.ql
ql/cpp/ql/src/Likely Bugs/OO/IncorrectConstructorDelegation.ql
ql/cpp/ql/src/Likely Bugs/OO/NonVirtualDestructorInBaseClass.ql
ql/cpp/ql/src/Likely Bugs/OO/ThrowInDestructor.ql
ql/cpp/ql/src/Likely Bugs/ReturnConstTypeMember.ql
ql/cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql
ql/cpp/ql/src/Likely Bugs/Underspecified Functions/TooManyArguments.ql
ql/cpp/ql/src/jsf/4.07 Header Files/AV Rule 35.ql
ql/cpp/ql/src/jsf/4.10 Classes/AV Rule 71.1.ql
ql/cpp/ql/src/jsf/4.10 Classes/AV Rule 79.ql
ql/cpp/ql/src/jsf/4.24 Control Flow Structures/AV Rule 197.ql
4 changes: 3 additions & 1 deletion cpp/ql/src/Best Practices/BlockWithTooManyStatements.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@
* @problem.severity recommendation
* @precision high
* @id cpp/complex-block
* @tags testability
* @tags quality
* testability
* readability
* maintainability
* complexity
*/

import cpp
Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Best Practices/ComplexCondition.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@
* @problem.severity recommendation
* @precision high
* @id cpp/complex-condition
* @tags testability
* @tags quality
* testability
* readability
* maintainability
* complexity
* statistical
* non-attributable
*/
Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Best Practices/Exceptions/AccidentalRethrow.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
* @problem.severity warning
* @precision high
* @id cpp/rethrow-no-exception
* @tags reliability
* @tags quality
* reliability
* correctness
* error-handling
* exceptions
*/

Expand Down
5 changes: 4 additions & 1 deletion cpp/ql/src/Best Practices/Exceptions/CatchingByValue.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@
* @problem.severity warning
* @precision very-high
* @id cpp/catch-by-value
* @tags efficiency
* @tags quality
* reliability
* efficiency
* correctness
* error-handling
* exceptions
*/

Expand Down
5 changes: 4 additions & 1 deletion cpp/ql/src/Best Practices/Exceptions/LeakyCatch.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@
* @problem.severity warning
* @precision high
* @id cpp/catch-missing-free
* @tags efficiency
* @tags quality
* reliability
* efficiency
* correctness
* error-handling
* exceptions
* external/cwe/cwe-401
*/
Expand Down
5 changes: 4 additions & 1 deletion cpp/ql/src/Best Practices/Exceptions/ThrowingPointers.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@
* @problem.severity warning
* @precision high
* @id cpp/throwing-pointer
* @tags efficiency
* @tags quality
* reliability
* efficiency
* correctness
* error-handling
* exceptions
*/

Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Best Practices/GuardedFree.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
* @problem.severity recommendation
* @precision very-high
* @id cpp/guarded-free
* @tags maintainability
* @tags quality
* maintainability
* readability
* useless-code
*/

import cpp
Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Best Practices/Hiding/DeclarationHidesParameter.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @problem.severity recommendation
* @precision very-high
* @id cpp/declaration-hides-parameter
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Best Practices/Hiding/DeclarationHidesVariable.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @problem.severity recommendation
* @precision high
* @id cpp/declaration-hides-variable
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Best Practices/Likely Errors/Slicing.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @problem.severity warning
* @precision high
* @id cpp/slicing
* @tags reliability
* @tags quality
* reliability
* correctness
* types
*/
Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Best Practices/RuleOfTwo.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* @problem.severity warning
* @precision high
* @id cpp/rule-of-two
* @tags reliability
* @tags quality
* reliability
* readability
* language-features
*/
Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Best Practices/UseOfGoto.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
* @problem.severity warning
* @precision high
* @id cpp/use-of-goto
* @tags maintainability
* @tags quality
* maintainability
* readability
* complexity
* language-features
*/

Expand Down
5 changes: 4 additions & 1 deletion cpp/ql/src/Critical/LargeParameter.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
* @problem.severity recommendation
* @precision very-high
* @id cpp/large-parameter
* @tags efficiency
* @tags quality
* reliability
* performance
* efficiency
* readability
* statistical
* non-attributable
Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Critical/NewArrayDeleteMismatch.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity warning
* @precision high
* @id cpp/new-array-delete-mismatch
* @tags reliability
* @tags quality
* reliability
* correctness
*/

import NewDelete
Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Critical/NewDeleteArrayMismatch.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* @problem.severity warning
* @precision high
* @id cpp/new-delete-array-mismatch
* @tags reliability
* @tags quality
* reliability
* correctness
*/

import NewDelete
Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Documentation/FixmeComments.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @problem.severity recommendation
* @precision very-high
* @id cpp/fixme-comment
* @tags maintainability
* @tags quality
* maintainability
* documentation
* external/cwe/cwe-546
*/
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/src/Header Cleanup/Cleanup-DuplicateIncludeGuard.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @problem.severity error
* @precision high
* @id cpp/duplicate-include-guard
* @tags reliability
* @tags quality
* maintainability
* modularity
*/
Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Arithmetic/BitwiseSignCheck.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* @problem.severity warning
* @precision high
* @id cpp/bitwise-sign-check
* @tags reliability
* @tags quality
* reliability
* correctness
*/

Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Arithmetic/ComparisonPrecedence.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* @problem.severity warning
* @precision very-high
* @id cpp/comparison-precedence
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Arithmetic/FloatComparison.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* @problem.severity recommendation
* @precision high
* @id cpp/equality-on-floats
* @tags reliability
* @tags quality
* reliability
* correctness
*/

Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Arithmetic/PointlessComparison.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
* @problem.severity warning
* @precision high
* @id cpp/constant-comparison
* @tags maintainability
* @tags quality
* maintainability
* readability
*/

Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Arithmetic/PointlessSelfComparison.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* @problem.severity warning
* @precision high
* @id cpp/comparison-of-identical-expressions
* @tags readability
* @tags quality
* readability
* maintainability
*/

Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Likely Bugs/Arithmetic/UnsignedGEZero.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
* @problem.severity warning
* @precision very-high
* @id cpp/unsigned-comparison-zero
* @tags maintainability
* @tags quality
* reliability
* correctness
* readability
*/

Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Likely Bugs/ContinueInFalseLoop.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
* @id cpp/continue-in-false-loop
* @problem.severity warning
* @precision high
* @tags correctness
* @tags quality
* reliability
* correctness
*/

import cpp
Expand Down
4 changes: 3 additions & 1 deletion cpp/ql/src/Likely Bugs/Conversion/ArrayArgSizeMismatch.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
* @id cpp/array-arg-size-mismatch
* @problem.severity warning
* @precision high
* @tags reliability
* @tags quality
* reliability
* correctness
*/

import cpp
Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Conversion/ImplicitDowncastFromBitfield.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* @problem.severity warning
* @precision high
* @id cpp/implicit-bitfield-downcast
* @tags reliability
* @tags quality
* reliability
* correctness
* types
*/
Expand Down
3 changes: 2 additions & 1 deletion cpp/ql/src/Likely Bugs/Format/TooManyFormatArguments.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* @problem.severity recommendation
* @precision high
* @id cpp/too-many-format-arguments
* @tags reliability
* @tags quality
* reliability
* correctness
*/

Expand Down
Loading
Loading