[outreachy] t0081: Replace the old style 'test -f' to new 'test_path_is_file'

[shashu8660]

CC: Kaartic Sivaraam kaartic.sivaraam@gmail.com, Christian Couder christian.couder@gmail.com, Siddharth Asthana siddharthasthana31@gmail.com, Usman Akinyemi usmanakinyemi202@gmail.com
cc: Shashank S shashu8660@gmail.com

[gitgitgadget]

Welcome to GitGitGadget

Hi @shashu8660, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that either:

• Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
• Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net>

NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description,
because it will result in a malformed CC list on the mailing list. See
example.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

[gitgitgadget]

Invalid author email in 35ac57e: "109198739+shashu8660@users.noreply.github.com"

[gitgitgadget]

There is an issue in commit 699a98e:
t0081:

• The first line must be separated from the rest by an empty line

[dscho]

@shashu8660 you will want to add something informative after the t0081: prefix (via git commit --amend), for example "t0081: modernize the code testing whether a file exists" or something like that. If in doubt, look at other commits that did similar things, e.g. via git log -Gtest_path_is_file t/.

[dscho]

/allow

[gitgitgadget]

User shashu8660 is now allowed to use GitGitGadget.

WARNING: shashu8660 has no public email address set on GitHub; GitGitGadget needs an email address to Cc: you on your contribution, so that you receive any feedback on the Git mailing list. Go to https://github.com/settings/profile to make your preferred email public to let GitGitGadget know which email address to use.

[shashu8660]

@shashu8660 you will want to add something informative after the t0081: prefix (via git commit --amend), for example "t0081: modernize the code testing whether a file exists" or something like that. If in doubt, look at other commits that did similar things, e.g. via git log -Gtest_path_is_file t/.

thank you @dscho to point out my mistake I will change it right away and submit it later

[dscho]

I will change it right away and submit it later

@shashu8660 great! You might want to do a /preview just to double-check (it will send the email just to you, even if what you receive will look as if it had Cc:ed the mailing list, too).

[shashu8660]

/preview

[gitgitgadget]

Preview email sent as pull.2254.git.1791961877861.gitgitgadget@gmail.com

[shashu8660]

/preview

[gitgitgadget]

Preview email sent as pull.2254.git.1791962598776.gitgitgadget@gmail.com

[shashu8660]

/submit

[gitgitgadget]

Submitted as pull.2254.git.1791962806807.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-2254/shashu8660/update-t0081-v1

To fetch this version to local tag pr-2254/shashu8660/update-t0081-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-2254/shashu8660/update-t0081-v1

[gitgitgadget]

Usman Akinyemi wrote on the Git mailing list (how to reply to this email):

> From: Shashank <shashu8660@gmail.com>
>
> Replace the old-style shell `test -f` command with Git's modern
> `test_path_is_file`.
>
> This instance was found using:
> `git grep "test -[efd]" t/'
This is not necessary, remove it.
>
> Signed-off-by: Shashank <shashu8660@gmail.com>
> ---
>     [outreachy] t0081: Replace the old style 'test -f' to new
>     'test_path_is_file'
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2254%2Fshashu8660%2Fupdate-t0081-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2254/shashu8660/update-t0081-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2254
>
>  t/t0081-find-pack.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0081-find-pack.sh b/t/t0081-find-pack.sh
> index ff9d56fbf1..7d5082c487 100755
> --- a/t/t0081-find-pack.sh
> +++ b/t/t0081-find-pack.sh
> @@ -32,7 +32,7 @@ test_expect_success 'repack everything into a single packfile' '
>                 ".git/objects/pack/pack-"*".pack") true ;;
>                 *) false ;;
>         esac &&
> -       test -f "$head_commit_pack" &&
> +       test_path_is_file "$head_commit_pack" &&
looks good to me.
>
>         # Everything is in the same pack
>         test "$head_commit_pack" = "$head_tree_pack" &&
>
> base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
> --
> gitgitgadget
Thanks.

[gitgitgadget]

Junio C Hamano wrote on the Git mailing list (how to reply to this email):

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

>> From: Shashank <shashu8660@gmail.com>
>>
>> Replace the old-style shell `test -f` command with Git's modern
>> `test_path_is_file`.
>>
>> This instance was found using:
>> `git grep "test -[efd]" t/'
> This is not necessary, remove it.

Since many candidates are working on similar microprojects (which is
fine) and making the same mistakes (which is expected), perhaps mentors
should tell them to read the review exchanges on other candidates'
patches and learn from them, instead of or in addition to giving the
same advice repeatedly.

[shashu8660]

/preview

[gitgitgadget]

Preview email sent as pull.2254.v2.git.1792060619781.gitgitgadget@gmail.com

[shashu8660]

/preview

[gitgitgadget]

Preview email sent as pull.2254.v2.git.1792061115751.gitgitgadget@gmail.com

[shashu8660]

/submit

[gitgitgadget]

Submitted as pull.2254.v2.git.1792061236183.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-2254/shashu8660/update-t0081-v2

To fetch this version to local tag pr-2254/shashu8660/update-t0081-v2:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-2254/shashu8660/update-t0081-v2

[gitgitgadget]

Shashank S wrote on the Git mailing list (how to reply to this email):

On Wed, 14 Oct 2026 at 15:19, Usman Akinyemi <usmanakinyemi202@gmail.com> wrote:
>
> > From: Shashank <shashu8660@gmail.com>
> >
> > Replace the old-style shell `test -f` command with Git's modern
> > `test_path_is_file`.
> >
> > This instance was found using:
> > `git grep "test -[efd]" t/'
> This is not necessary, remove it.

thank you for the review , i will remove it and i will submit patch v2

[gitgitgadget]

User Shashank S <shashu8660@gmail.com> has been added to the cc: list.

[gitgitgadget]

Shashank S wrote on the Git mailing list (how to reply to this email):

On Thu, 15 Oct 2026 at 03:17, Junio C Hamano <gitster@pobox.com> wrote:
>
> Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
>
> >> From: Shashank <shashu8660@gmail.com>

> Since many candidates are working on similar microprojects (which is
> fine) and making the same mistakes (which is expected), perhaps mentors
> should tell them to read the review exchanges on other candidates'
> patches and learn from them, instead of or in addition to giving the
> same advice repeatedly.

thank you for the explanation and the review , from now on i will go
through the other candidates patches and look in to them and  mentor
reviews in them and learn from that

[gitgitgadget]

Kaartic Sivaraam wrote on the Git mailing list (how to reply to this email):

On 10/15/26 03:17, Junio C Hamano wrote:
> Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
> >>> From: Shashank <shashu8660@gmail.com>
>>>
>>> Replace the old-style shell `test -f` command with Git's modern
>>> `test_path_is_file`.
>>>
>>> This instance was found using:
>>> `git grep "test -[efd]" t/'
>> This is not necessary, remove it.
> > Since many candidates are working on similar microprojects (which is
> fine) and making the same mistakes (which is expected), perhaps mentors
> should tell them to read the review exchanges on other candidates'
> patches and learn from them, instead of or in addition to giving the
> same advice repeatedly.

I agree that it is a good advice to ask candidate to read other candidates' patches. We do recommend this in our guide related to working on Microprojects:

 https://git.github.io/General-Microproject-Information/#research-existing-related-work

That said, I just wanted to highlight one thing. In the Microproject ideas page[1], we have the following for this specific idea:

  Notes

  - Start small: Pick a test file with just a few instances to convert
  - Run the test suite after your changes to ensure nothing breaks
  - Follow Git’s commit message style
  - Include which command you used to find the instances in your commit
    message

So, we can't really blame the candidates for including the command in the commit message. It is our mistake asking them to include it in the first place when we don't prefer it to be present there.

I raised a PR to fix that:

  https://github.com/git/git.github.io/pull/875

[1]: https://git.github.io/SoC-2026-Microprojects/

-- 
Sivaraam