Repository navigation
feat(boto3): Add Secrets Manager extension - #8046
Open
pabloDeputter wants to merge 4 commits into
Open
pabloDeputter wants to merge 4 commits into
pabloDeputter wants to merge 4 commits into
Conversation
pabloDeputter
changed the base branch from
pablo/boto3-s3-object-ops
to
major/3.0
October 16, 2026 15:32
- set `aws.secretsmanager.secret.arn` from an ARN `SecretId`, replaced by the response `ARN` - set `aws.secretsmanager.secret.name` from the response `Name`
pabloDeputter
force-pushed
the
pablo/boto3-add-secretsmanager-extension
branch
from
October 16, 2026 15:33
414e28b to
77db692
Compare
Contributor
Coverage Results 📊✅ 56247 passed | ⏭️ 2872 skipped | Total: 59119 | Pass Rate: 95.14% | Execution Time: 155m 36s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00% (23 of 23 changed executable lines covered; target 80%). Changed files with executable lines (2)
Coverage diff@@ Coverage Diff @@
## master #8046 +/-##
==========================================
- Coverage 90.25% 90.06% -0.19%
==========================================
Files 202 197 -5
Tracked lines 26660 20993 -5667
Branches 9926 7212 -2714
==========================================
- Hits 24062 18907 -5155
+ Misses 2598 2086 -512
+ Partials 1510 1234 -276Generated by Coverage Action |
pabloDeputter
changed the title
pabloDeputter
marked this pull request as ready for review
October 16, 2026 16:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the following attributes:
aws.secretsmanager.secret.arn(OTel): from an ARNSecretID, replaced by the responseARN(if available).aws.secretsmanager.secret.name(feat(attributes): Add AWS Lambda, Step Functions and Secrets Manager name attributes sentry-conventions#716): from responseNameor the requestNameorSecretId, else the ARN without its random-XXXXXXsuffix (in case of failed calls).The actual secret values are never read.
Issues
Resolves #7574