Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under Node >= 24.13 the SDK injects instrumentation via Module.registerHooks, which tsx's CJS loader bypasses. Keep the pin until #25351 lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 14, 2026 15:55
s1gr1d
approved these changes
Oct 14, 2026
Member
There was a problem hiding this comment.
Nice! Two notes:
- #25334 removes all
volta.pnpmpins, including the nuxt-5 ones (because you mentioned the nuxt-5 app in the description) - For future pins, I'd use
devEngines.runtimeinstead of using Volta here: pnpm 12 downloads that Node version itself, andsetup-nodealso looks at this field
JPeer264
approved these changes
Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most e2e apps that pinned their own Node version did so to run on something newer than the old Node 20 base. Since #24343 moved the root to Node 24.21.0, those pins are either redundant or now older than the root (e.g. the
24.15.0pins), so every app now simply extends the root Volta config.This also drops the Node 20 pin that #24343 added to
react-send-to-sentryas a stopgap, since it passes on Node 24 now.Two overrides remain:
11.10.0innuxt-5andnuxt-5-sourcemaps, which was bumped deliberately in test(e2e): Enable nuxt-5 as optional #22017.20.19.5intsx-express. On Node >= 24.13 the SDK injects instrumentation throughModule.registerHooks, whoseloadhook tsx's CJS loader bypasses (it replacesModule._extensionsand calls_compiledirectly), so Express is never instrumented. fix(node): restore tsx runtime instrumentation #25351 fixes this; the pin can go once it lands.🤖 Generated with Claude Code