fix(core): Handle callback errors by adinauer · Pull Request #6140 · getsentry/sentry-java

adinauer · 2026-09-22T04:33:18Z

PR Stack (Callback Errors)

📜 Description

Collects the callback error handling PR stack. The collection branch intentionally contains only an empty commit; the implementation lands through the stacked PRs below it.

💡 Motivation and Context

Filtering callback failures must not allow potentially partially processed telemetry to continue through the pipeline. This stack distinguishes callback failures in client reports and consistently drops affected telemetry or breadcrumbs.

resolves: Align callback error handling with other SDKs #6081

💚 How did you test it?

The cumulative stack passes focused sentry tests for SentryClientTest, ScopeTest, ScopesTest, and ClientReportTest, plus :sentry:apiCheck.

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.
Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Merge the stack PRs bottom to top using merge commits, then squash-merge this collection PR into main.

sentry · 2026-09-22T04:34:59Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
SDK Size	io.sentry.tests.size	8.60.0 (1)	release

⚙️ sentry-android Build Distribution Settings

Add the callback_error discard reason and use it when a beforeSend callback throws. Preserve before_send for callbacks that intentionally return null and retain item, span, and byte accounting. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Stop processing and drop telemetry when an event processor throws. Record callback_error outcomes for every supported category instead of sending potentially partially processed data. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Drop breadcrumbs when beforeBreadcrumb throws instead of storing the breadcrumb with exception details. Keep observer state unchanged and release the callback reentrancy guard for later additions. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Add an internal marker to SDK event processors across core and integrations. Keep customer processors and the backfilling marker independent so later callback handling can distinguish ownership regardless of registration path. Leave exception handling unchanged in this preparatory change. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Make the preceding marker PR available to the processor failure policy. Preserve the existing stack commits and leave failure behavior unchanged. Co-Authored-By: Claude <noreply@anthropic.com>

Carry the inserted SDK processor marker forward through the adjacent stack branch without rewriting existing history or changing breadcrumb behavior. Co-Authored-By: Claude <noreply@anthropic.com>

Use the internal processor marker to continue processing after SDK-owned processor failures without recording callback_error losses. Keep customer processor failures fail-closed across events, transactions, replays, feedback, logs, and metrics. Cover scope and options registration, continued callbacks and delivery, logging without discard notifications, intentional drops, and span loss accounting. Clarify the customer-only failure policy in the changelog. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Merge #6142 forward into #6143 so SDK-owned processor failures preserve\ntelemetry throughout the stack. Keep the breadcrumb-only diff unchanged\nand retain both changelog entries without rewriting existing history.

Inherit the parent sampling decision when tracesSampler throws. Without a parent decision, leave the trace unsampled instead of applying the static tracesSampleRate, which can override the failed sampling policy. Keep normal null-result fallback, profiling callbacks, and catch types unchanged. Cover parent inheritance, backfilling, and static-rate bypass. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the tracesSampler failure fallback entry to #6163 in the callback error handling stack.

Disable profiling when profilesSampler throws instead of applying the static profilesSampleRate or inheriting a parent profiling decision. Preserve trace sampling metadata and normal null-result fallback. Cover static-rate bypass, parent inheritance, and failures in both samplers without changing existing catch types. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the profilesSampler failure handling entry to #6164 in the callback error handling stack.

Skip replay capture when beforeErrorSampling throws instead of capturing replay after a failed user filter. Continue sending the error event and retain existing exception logging and catch types. Cover handled errors, crashes, and successful replay capture after a previous callback failure. Verify error delivery and failure logging. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the beforeErrorSampling failure entry to PR #6165. Co-Authored-By: Claude <noreply@anthropic.com>

Record callback_error/profile when beforeSendTransaction or a customer transaction processor throws and an attached profile is dropped. Notify OnDiscardCallback through the same client-report accounting path. Cover scope and options processors, absent profiles, and SDK processor failures that retain profiles. Leave catch types, intentional drops, and profile-file cleanup unchanged. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the transaction profile loss accounting entry to PR #6166. Co-Authored-By: Claude <noreply@anthropic.com>

Skip Android screenshot and view hierarchy capture when their callbacks throw, while retaining the error event. Drop spans on beforeSpan failures in OkHttp, OpenFeign, GraphQL, Ktor, and Apollo without disrupting requests or replacing the original request error. Preserve normal callback results and existing catch types. Finish failed spans and retain request cleanup and breadcrumbs. Add regression coverage for callback failures, partial mutations, original request errors, asynchronous GraphQL results, and subsequent Android captures. Correct callback wiring in the Ktor and screenshot test fixtures. Verify 18 regression cases fail before the fix and pass afterward; all 454 tests in the affected suites pass, along with formatting and API checks. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

Link the Android capture and integration beforeSpan callback fixes to Callback Errors 9 (#6167). Co-Authored-By: Claude <noreply@anthropic.com>

…ndling-user-feedback

…ndling-spring-user-provider

…ndling-spring-transaction-name-provider

…pollo-5 fix(apollo5): Handle beforeSpan callback failures

Identify which SentryUserProvider failed when multiple providers are configured, making callback failures actionable across all Spring variants. Refs GH-6240 Co-Authored-By: Claude <noreply@anthropic.com>

…ndling-spring-user-provider

…pring-user-provider fix(spring): Handle user provider failures

Ensure a failed legacy configuration does not prevent the configurator from receiving the original feedback options and applying its changes. Co-Authored-By: Claude <noreply@anthropic.com>

Ensure fatal errors from the feedback options configurator are rethrown instead of being handled as recoverable callback failures. Co-Authored-By: Claude <noreply@anthropic.com>

…ndling-user-feedback

…ndling-spring-transaction-name-provider

…ser-feedback fix(android): Handle feedback configurator failures

…ndling-spring-transaction-name-provider

…pring-transaction-name-provider fix(spring): Handle transaction name provider failures

Move the callback error handling entry back to Unreleased and group the related changes by impact so the full behavior change is documented in one place. Co-Authored-By: Claude <noreply@anthropic.com>

Catch nonfatal Throwable failures from newly guarded customer callbacks while continuing to propagate fatal JVM errors. This keeps callback isolation consistent without introducing new fatal-error swallowing. Add regression coverage for nonfatal fallback behavior and fatal error propagation across the affected integrations. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

…o fix/callback-error-handling-nonfatal-throwables

Keep Apollo 2's existing Exception boundary unchanged so non-Exception errors retain their released behavior. Limit the broader nonfatal Throwable handling to callback guards introduced by the unreleased stack. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>

* fix(callbacks): Handle nonfatal callback throwables Catch nonfatal Throwable failures from newly guarded customer callbacks while continuing to propagate fatal JVM errors. This keeps callback isolation consistent without introducing new fatal-error swallowing. Add regression coverage for nonfatal fallback behavior and fatal error propagation across the affected integrations. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com> * changelog * fix(callbacks): Preserve Apollo 2 error handling Keep Apollo 2's existing Exception boundary unchanged so non-Exception errors retain their released behavior. Limit the broader nonfatal Throwable handling to callback guards introduced by the unreleased stack. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>

lbloder

LGTM 👍

collection: callback error handling

468abd9

adinauer mentioned this pull request Sep 22, 2026

fix(core): [Callback Errors 1] Report callback failures #6141

Merged

6 of 9 tasks

adinauer mentioned this pull request Sep 22, 2026

fix(core): [Callback Errors 3] Drop failed processor data #6142

Merged

5 of 9 tasks

adinauer mentioned this pull request Sep 22, 2026

fix(core): [Callback Errors 4] Drop failed breadcrumbs #6143

Merged

5 of 9 tasks

adinauer mentioned this pull request Sep 24, 2026

ref(core): [Callback Errors 2] Mark SDK-owned event processors #6162

Merged

4 of 9 tasks

adinauer and others added 5 commits September 24, 2026 14:50

Merge SDK processor marker into processor callback handling

8b3c3fa

Make the preceding marker PR available to the processor failure policy. Preserve the existing stack commits and leave failure behavior unchanged. Co-Authored-By: Claude <noreply@anthropic.com>

Merge processor stack update into breadcrumb callback handling

aa17ea5

Carry the inserted SDK processor marker forward through the adjacent stack branch without rewriting existing history or changing breadcrumb behavior. Co-Authored-By: Claude <noreply@anthropic.com>

chore(core): Sync processor fixes into breadcrumb stack

8a06fde

Merge #6142 forward into #6143 so SDK-owned processor failures preserve\ntelemetry throughout the stack. Keep the breadcrumb-only diff unchanged\nand retain both changelog entries without rewriting existing history.

adinauer mentioned this pull request Sep 24, 2026

fix(core): [Callback Errors 5] Handle tracesSampler failures #6163

Merged

4 of 9 tasks

adinauer and others added 2 commits September 24, 2026 15:49

changelog

60d1e15

Link the tracesSampler failure fallback entry to #6163 in the callback error handling stack.

adinauer mentioned this pull request Sep 24, 2026

fix(core): [Callback Errors 6] Handle profilesSampler failures #6164

Merged

4 of 9 tasks

adinauer and others added 2 commits September 24, 2026 16:35

changelog

aa15164

Link the profilesSampler failure handling entry to #6164 in the callback error handling stack.

adinauer mentioned this pull request Sep 24, 2026

fix(core): [Callback Errors 7] Handle replay sampling failures #6165

Merged

4 of 9 tasks

adinauer and others added 2 commits September 24, 2026 16:53

changelog

b62c094

Link the beforeErrorSampling failure entry to PR #6165. Co-Authored-By: Claude <noreply@anthropic.com>

adinauer mentioned this pull request Sep 25, 2026

fix(core): [Callback Errors 8] Report dropped profiles #6166

Merged

4 of 9 tasks

adinauer and others added 2 commits September 25, 2026 05:49

changelog

7a471df

Link the transaction profile loss accounting entry to PR #6166. Co-Authored-By: Claude <noreply@anthropic.com>

adinauer mentioned this pull request Sep 25, 2026

fix(integrations): [Callback Errors 9] Guard custom callbacks #6167

Merged

4 of 9 tasks

changelog

44ed7c6

Link the Android capture and integration beforeSpan callback fixes to Callback Errors 9 (#6167). Co-Authored-By: Claude <noreply@anthropic.com>

linear-code Bot mentioned this pull request Sep 25, 2026

Align callback error handling with other SDKs #6081

Closed

adinauer and others added 15 commits October 9, 2026 06:51

Merge branch 'fix/callback-error-handling' into fix/callback-error-ha…

6ecd2a9

…ndling-user-feedback

Merge branch 'fix/callback-error-handling' into fix/callback-error-ha…

35555aa

…ndling-spring-user-provider

Merge branch 'fix/callback-error-handling' into fix/callback-error-ha…

37872d9

…ndling-spring-transaction-name-provider

Merge pull request #6238 from getsentry/fix/callback-error-handling-a…

db0ed76

…pollo-5 fix(apollo5): Handle beforeSpan callback failures

fix(spring): Include user provider name in error log

27184c6

Identify which SentryUserProvider failed when multiple providers are configured, making callback failures actionable across all Spring variants. Refs GH-6240 Co-Authored-By: Claude <noreply@anthropic.com>

Merge branch 'fix/callback-error-handling' into fix/callback-error-ha…

5c639a8

…ndling-spring-user-provider

Merge pull request #6240 from getsentry/fix/callback-error-handling-s…

84e8b86

…pring-user-provider fix(spring): Handle user provider failures

test(android): Verify configurator runs after configuration failure

e32efe0

Ensure a failed legacy configuration does not prevent the configurator from receiving the original feedback options and applying its changes. Co-Authored-By: Claude <noreply@anthropic.com>

test(android): Verify configurator propagates fatal errors

08377ad

Ensure fatal errors from the feedback options configurator are rethrown instead of being handled as recoverable callback failures. Co-Authored-By: Claude <noreply@anthropic.com>

Merge branch 'fix/callback-error-handling' into fix/callback-error-ha…

2afa056

…ndling-user-feedback

Merge branch 'fix/callback-error-handling' into fix/callback-error-ha…

c381657

…ndling-spring-transaction-name-provider

Merge pull request #6239 from getsentry/fix/callback-error-handling-u…

155fa5a

…ser-feedback fix(android): Handle feedback configurator failures

Merge branch 'fix/callback-error-handling' into fix/callback-error-ha…

bec3873

…ndling-spring-transaction-name-provider

Merge pull request #6241 from getsentry/fix/callback-error-handling-s…

6dffaa7

…pring-transaction-name-provider fix(spring): Handle transaction name provider failures

Merge branch 'main' into fix/callback-error-handling

13094aa

adinauer marked this pull request as ready for review October 13, 2026 08:13

adinauer requested review from 0xadam-brown, markushi, romtsn and runningcode as code owners October 13, 2026 08:13

adinauer and others added 3 commits October 13, 2026 12:25

docs(changelog): Consolidate callback error fixes

6e59919

Move the callback error handling entry back to Unreleased and group the related changes by impact so the full behavior change is documented in one place. Co-Authored-By: Claude <noreply@anthropic.com>

Merge remote-tracking branch 'origin/fix/callback-error-handling' int…

dea4dd8

…o fix/callback-error-handling-nonfatal-throwables

adinauer mentioned this pull request Oct 13, 2026

fix(callbacks): [Callback Errors 10] Handle nonfatal throwables #6251

Merged

6 of 9 tasks

adinauer and others added 3 commits October 13, 2026 12:32

changelog

d04cc24

lbloder approved these changes Oct 13, 2026

View reviewed changes

adinauer merged commit e6ec71a into main Oct 13, 2026
73 of 74 checks passed

adinauer deleted the fix/callback-error-handling branch October 13, 2026 14:57

Navigation Menu

Repository navigation

fix(core): Handle callback errors - #6140

fix(core): Handle callback errors#6140
adinauer merged 77 commits into
mainfrom
fix/callback-error-handling

adinauer commented Sep 22, 2026 •

edited

Loading

Uh oh!

sentry Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

lbloder left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adinauer commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Stack (Callback Errors)

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

sentry Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

lbloder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adinauer commented Sep 22, 2026 •

edited

Loading

sentry Bot commented Sep 22, 2026 •

edited

Loading