Skip to content

Fix #15063 FP knownArgument when there is function pointer call #8935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix #15063 FP knownArgument when there is function pointer call #8935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae0ca48
Update vf_settokenvalue.cpp
chrchr-github Oct 12, 2026
33fe927
Update testother.cpp
chrchr-github Oct 12, 2026
ee06c45
Update testother.cpp
chrchr-github Oct 12, 2026
7562504
Update vf_settokenvalue.cpp [skip ci]
chrchr-github Oct 13, 2026
5ea92e6
Update testother.cpp
chrchr-github Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/vf_settokenvalue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ namespace ValueFlow
// Ensure that the comma isn't a function call
if (!callParent || (!Token::Match(callParent->previous(), "%name%|> (") && !Token::simpleMatch(callParent, "{") &&
(!Token::Match(callParent, "( %name%") || settings.library.isNotLibraryFunction(callParent->next())) &&
!(callParent->str() == "(" && (Token::simpleMatch(callParent->astOperand1(), "*") || Token::Match(callParent->astOperand1(), "%name%|("))))) {
!(callParent->str() == "(" && Token::Match(callParent->astOperand1(), "%name%|(|[|*|.")))) {
setTokenValue(parent, std::move(value), settings);
return;
}
Expand Down
12 changes: 12 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13682,6 +13682,18 @@ class TestOther : public TestFixture {
" return MACRO(true);\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("struct S {\n" // #15063
" int (*f)(int, int);\n"
" int (*a[2])(int, int);\n"
"};\n"
"int g1(struct S* p, int x) {\n"
" return (p->f)(x, 10);\n"
"}\n"
"int g2(struct S s, int x) {\n"
" return s.a[0](x, 10);\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void knownArgumentHiddenVariableExpression() {
Expand Down
Loading