Skip to content

Keep partially consumed tab when an HTML block starts or continues in a block quote #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shaisolaris wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Keep partially consumed tab when an HTML block starts or continues in a block quote #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions commonmark/src/main/java/org/commonmark/internal/DocumentParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,10 @@ private void findNextNonSpace() {
}

private void setNewIndex(int newIndex) {
if (newIndex == index) {
// Staying where we are, so keep a partially consumed tab (e.g. after ">\t") as it is
return;
}
if (newIndex >= nextNonSpace) {
// We can start from here, no need to calculate tab stops again
index = nextNonSpace;
Expand Down
8 changes: 8 additions & 0 deletions commonmark/src/test/java/org/commonmark/test/SpecialInputTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,4 +463,12 @@ public void codeSpansAfterUnclosedBackticks() {
assertRendering(
"`` `a` `c` `e`", "<p>`` <code>a</code> <code>c</code> <code>e</code></p>\n");
}

@Test
public void htmlBlockInBlockQuoteAfterPartiallyConsumedTab() {
// The tab after ">" is 3 columns wide; one is consumed by the block quote marker and the
// remaining 2 belong to the HTML block content, same as for other block types
assertRendering(">\t<div>", "<blockquote>\n <div>\n</blockquote>\n");
assertRendering("> <div>\n>\tfoo", "<blockquote>\n<div>\n foo\n</blockquote>\n");
}
}