Skip to content

feat(workspaces): implement the workspace panel components - #1154

Draft
EhabY wants to merge 6 commits into
mainfrom
feat/vsc-1-workspaces-panel
Draft

EhabY wants to merge 6 commits into
mainfrom
feat/vsc-1-workspaces-panel

Conversation

@EhabY

@EhabY EhabY commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Implements VSC-1: an experimental Workspaces tree built on @repo/ui, with filtering, inline actions, app statuses, live metadata, and blue Agent badges based on actual chat associations.

Uses standard 22px rows, 16px icons/loaders, native typography and selection colors. The native Coder Remote: Workspaces toolbar owns refresh and deployment actions. The webview has a quiet All/Mine/Shared text-and-chevron filter, hides owners in Mine, and uses Template + Status row hovers. Refresh does not move rows. State-aware lifecycle actions and diagnostics share the existing … menu; unwired actions remain disabled. Command objects and unchanged pushed JSON subtrees remain stable for memoization.

Approved implementation plan and decisions
  1. Replace the JSON placeholder with WorkspacesPanel using the existing useWorkspaces hook and typed IPC.
  2. Render one workspace tree and a functional All/Mine/Shared filter; defer search. Use existing DropdownMenu, Button, and radio-menu primitives for the quiet filter, respecting capabilities and marking the active choice.
  3. Follow the revised design: status dots, truncated names, owners only in All/Shared, inline actions, agent/container hierarchy, and expandable metadata. Workspace hovers show Template + Status; agent hovers show Status. Action hovers do not repeat names.
  4. Reuse Tree navigation, menus, tooltips, state panels, Icon, Spinner, and StatusPill. Preserve expansion and populated data during refresh; overlay progress without moving rows; watch only expanded visible metadata. Preserve high-contrast status outlines without selection-only rings.
  5. Wire supported open/dashboard/settings/refresh actions. Reuse native Switch Deployment, Logout, and Network Check commands in the view-title menu, without Create Workspace. Keep unsupported lifecycle, sharing, deletion, and row diagnostics disabled.
  6. Keep diagnostics in the existing workspace … menu, without a separate right-click menu. Group lifecycle actions, Settings/Share, diagnostics, then Delete. Remove Change version. Running offers Stop/Restart; stopped Start; failed/canceled Retry; other states omit lifecycle actions.
  7. Keep two consolidated Workspaces story files and one focused shared Tree regression story. Verify behavior tests, typecheck, lint, formatting, build, browser geometry, and all four themes. Tests/comments protect meaningful contracts, not removed wording.

Repository comparisons: Coder's Workspaces overflow menu supports using one menu. Lifecycle choices take inspiration from dashboard status abilities. The user approved Retry for canceled builds instead of copying the dashboard's simultaneous Start/Stop choices.

Menu diagnosis: When another row had focus, pointer entry into the portal hid the trigger and moved the popup from (140, 74) to (0, 2). The Tree action bar stays visible through Base UI's existing open-popup attribute. The original pointer repro and shared regression story pass.

Agent badge: One batched API.experimental.getChatsByWorkspace lookup follows each successful nonempty list refresh, after publishing the ready list. Only associated listed workspace IDs are pushed, never chat IDs. Metadata updates do not fetch associations. Stale session/filter responses are ignored; denied/unavailable endpoints are suppressed until a filter/session change or manual refresh. This small IPC enrichment was approved during follow-up; Task IDs are not a substitute.

Refresh policy: Mine polls about every 5 seconds after a completed list cycle while visible. All/Shared are on demand. Metadata uses WebSocket with SSE fallback, retains streams for 15 seconds after release, and currently keeps them while the view is hidden.

Verified after rebase: 477 webview tests, 69 affected extension tests, full typecheck/lint/format/build/diff checks. All 44 relevant story/theme combinations passed, including both high-contrast themes and the shared Tree regression. Actual pointer checks at 240px and 360px confirmed bounded menus, stable anchoring, Settings dispatch, and compact row hovers in all four themes. Refresh caused zero row shift. Removal controls caught lifecycle, hover, filter dispatch, and disabled-diagnostics regressions. No live-deployment UAT or native view-title menu visual verification performed. Screenshots are available in the chat; no repository image files added.

Diff line counts

Git diff vs main, including comments and blank lines. Test support includes @repo/mocks and test/mocks.

Category Added Removed Net
Production 861 17 +844
Tests 553 3 +550
Stories 601 0 +601
Test support 44 0 +44
Docs/config 29 5 +24
Total 2,088 25 +2,063

Generated by Coder Agents on behalf of @EhabY.

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

VSC-1

EhabY added 4 commits October 15, 2026 16:55
Consolidate story coverage and capture native tooltips in all themes.\n\nGenerated by Coder Agents on behalf of @EhabY.
Keep open-menu triggers visible after focus leaves their row. Move refresh to the native view toolbar and preserve unchanged IPC snapshot references.

Generated by Coder Agents on behalf of @EhabY.
Batch association lookups without blocking the workspace list, preserve snapshot sharing, and suppress unavailable endpoints until explicit refresh.

Generated by Coder Agents on behalf of @EhabY.
@EhabY
EhabY force-pushed the feat/vsc-1-workspaces-panel branch from 7f68832 to ef754fd Compare October 15, 2026 13:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant